Update memory_size() calculation for tracked_transaction #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
reviewed
Apr 23, 2022
| @@ -51,10 +51,7 @@ struct tracked_transaction { | |||
| return block_num != 0; | |||
| } | |||
There was a problem hiding this comment.
The name is wrong in test/variant_estimated_size/CMakeLists.txt
add_test(NAME test_variant should be add_test(NAME variant_estimated_size
There was a problem hiding this comment.
this is already on fc's main so #128 is getting hung up by it. eosnetworkfoundation/mandel-fc#20
There was a problem hiding this comment.
@ClaytonCalabrese All you need to do now is update this PR to point to fc head of main.
heifner
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracked_transaction now uses the new fc::variant::estimated size function to more accurately estimate the size
This PR also ticks up the git commit for the fc submodule.
Some additional test changes may be needed.