Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: test contract fixes #459

Closed
linh2931 opened this issue Jun 20, 2022 · 1 comment · Fixed by #622
Closed

Backport: test contract fixes #459

linh2931 opened this issue Jun 20, 2022 · 1 comment · Fixed by #622
Assignees
Labels
OCI OCI working this issue...

Comments

@linh2931
Copy link
Member

EOSIO/eos#9114

Need to verify with Mandel CDT if those deprecated headers in eosio.cdt v1.7.x were removed. If they were removed, it is not possible to build EOSIO with -DEOSIO_COMPILE_TEST_CONTRACTS=true. A big task.

@oschwaldp-oci oschwaldp-oci self-assigned this Jul 1, 2022
@oschwaldp-oci oschwaldp-oci added the OCI OCI working this issue... label Jul 1, 2022
@oschwaldp-oci
Copy link
Contributor

Also required backport of: EOSIO/eos#9390

Resolves issue with StaticArray test by removing test:

 * Reason:
 * it was working in c++14 but fails in c++17 due to braces elision
 * 
 * Details:
 * In c++17 StaticArray can be constructed with {10,20} or {{10,20}} using braces elision feature
 * boost::pfr::for_each_field chosing constructor with maximum parameters available
 * which is 2 in commented out example and then it fails to compile here
 *    <skipped>/include/boost/pfr/detail/core17_generated.hpp:51:9: error: type 'StaticArray'
 *    decomposes into 1 elements, but 2 names were provided
 *    auto& [a,b] = val;
 * this issue is known by author of the library and is not resolved yet:
 * https://github.com/apolukhin/magic_get/issues/16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI OCI working this issue...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants