Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: Add trace plugin API test #427

Closed
linh2931 opened this issue Jun 18, 2022 · 3 comments · Fixed by #584
Closed

Backport: Add trace plugin API test #427

linh2931 opened this issue Jun 18, 2022 · 3 comments · Fixed by #584
Assignees
@oschwaldp-oci
Labels
3.2 Candidate OCI OCI working this issue...
Milestone
Mandel 3.2.0

Comments

@linh2931
Copy link
Member

EOSIO/eos#9194

trace_plugin_test.py was pulled into Mandel by the removing history plugin activity. But it was not enabled in CMakefile. Need to test and enable it.
@linh2931
Copy link
Member Author

This requires deduceAmount in testUtils.py which was originally introduced by EOSIO/eos#8931 and track by #399.

@oschwaldp-oci oschwaldp-oci self-assigned this Jun 29, 2022
@oschwaldp-oci oschwaldp-oci added 3.2 Candidate OCI OCI working this issue... labels Jun 29, 2022
@oschwaldp-oci
Copy link
Contributor

Looks like #399 didn't end up being backported due to the bug not manifesting in mandel. However, I think it would be wise to still backport the test and util updates, so I will endeavor to do that in this issue as well. Will not backport updates to cleos (though might need to at a future date if updating the json format).

Backports tests/* changes from EOSIO/eos#8931

@arhag arhag moved this to Todo in ENF Engineering Jun 30, 2022
@oschwaldp-oci
Copy link
Contributor

oschwaldp-oci commented Jun 30, 2022 •
edited
Loading

After further research, it looks like we need to backport: EOSIO/eos#8676 to get the data unpacking. Then the bug does resurface necessitating all of EOSIO/eos#8931.

So, will work this as 3 backports:

This was referenced Jun 30, 2022
Merged
Merged
oschwaldp-oci pushed a commit that referenced this issue Jun 30, 2022
@allenhan2 @oschwaldp-oci
GH-427 Merge pull request #9194 from EOSIO/trace_plugin_test
d5d9e20 
Add trace plugin  API test
oschwaldp-oci added a commit that referenced this issue Jun 30, 2022
@oschwaldp-oci
GH-427 Fix issue in getTransBlockNum where if except was None it woul…
770a700 
…d fail with no_block instead of returning the block number.
@oschwaldp-oci oschwaldp-oci mentioned this issue Jun 30, 2022
Merged
Repository owner moved this from Todo to Done in ENF Engineering Jul 1, 2022
@arhag arhag added this to the Mandel 3.2.0-rc1 milestone Jul 1, 2022
@stephenpdeos stephenpdeos modified the milestones: Mandel 3.2.0-rc1, Mandel 3.2.0 Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oschwaldp-oci oschwaldp-oci

Labels
3.2 Candidate OCI OCI working this issue...
Projects
ENF Engineering
Status: Done
Milestone
Mandel 3.2.0
Development

Successfully merging a pull request may close this issue.

[3.2] Backport: Add trace plugin API test eosnetworkfoundation/mandel
4 participants
@arhag @oschwaldp-oci @stephenpdeos @linh2931