React hooks test cases part 1 -- useLayoutEffect #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also reduce the timeout from 1e3 to 100. Skip shallow tests until [shallow renderer can run useEffect](facebook/react#15275) is fixed.
ljharb
approved these changes
May 11, 2019
ljharb
force-pushed
the
react-hooks-use-layout-effect
branch
from
3d0983b
to
1b85181
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2011 .
Added
useLayoutEffecttests with almost the same flow except that the component usinguseLayoutEffectinsteaduseEffect.The shallow test is also skipped due to facebook/react#15275 . After that resolves we should reopen those skipped tests.
Also reset the timeout of
setTimeoutin test from1e3to100-- hope to make tests a little sooner.