-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update after simulateError #1812
Add update after simulateError #1812
Conversation
f6787bd
to
d065042
Compare
d065042
to
880f64b
Compare
880f64b
to
3113da3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@ljharb I reverted the change and just left the tests, resulting in https://travis-ci.org/airbnb/enzyme/builds/427510199 (which is the expected failures). Im not really sure what the problem here might be |
e9ff3eb
to
86b77bc
Compare
Are there any additional changes to be made here? |
86b77bc
to
f7d51d2
Compare
@jgzuke this build: https://travis-ci.org/airbnb/enzyme/builds/429796257 still didn't fail (https://travis-ci.org/airbnb/enzyme/builds/429796341 is the one with the fix) :-/ basically, i want to see a failing build, that the fix fixes, to have confidence to merge this. |
Im a bit confused why https://travis-ci.org/airbnb/enzyme/builds/427510199 fails but https://travis-ci.org/airbnb/enzyme/builds/429796257 passes given they contain the same changes, are you sure Jenkins is actually running on the displayed commit and not on the end of that branch |
hmm, i'm pretty sure. i'll try pushing just the first commit, and i won't push the second til the test is done. |
f7d51d2
to
85ed936
Compare
guess that was it! i'll merge this shortly. |
- [new] `mount`: `.state()`/`.setState()`: allow calling on children (#1802) - [new] `configuration`: add `reset` - [fix] `makeOptions`: ensure that config-level `attachTo`/`hydrateIn` are inherited into wrapper options (#1836) - [fix] `shallow`/`Utils`: call into adapter’s `isCustomComponentElement` if present (#1832) - [fix] `shallow`/`mount`: throw an explicit error when state is null/undefined - [fix] freeze ROOT_NODES for child wrappers (#1811) - [fix] `shallow`: `.parents`: ensure that one `.find` call does not affect another (#1781) - [fix] `mount`: update after `simulateError` (#1812) - [refactor] `mount`/`shallow`: `getElement`: use `this.single` - [deps] update `babel-preset-airbnb`, `chai`, `eslint`, `mocha`, `enzyme-adapter-utils`, `react-is`, `airbnb-js-shims`
Fixes #1809
Note that
Will still fail, I will fix that separately.
@ljharb