Merge pull request #103 from airbnb/lmr--set-props-merge

Normalized setProps behavior between mount/shallow

package.json

@@ -47,6 +47,7 @@
   "license": "MIT",
   "dependencies": {
     "cheerio": "^0.19.0",
+    "object.assign": "^4.0.3",
     "sinon": "^1.15.4",
     "underscore": "^1.8.3"
   },

src/ReactWrapperComponent.jsx

@@ -1,4 +1,5 @@
 import React, { PropTypes } from 'react';
+import objectAssign from 'object.assign';
 
 /**
  * This is a utility component to wrap around the nodes we are
@@ -30,7 +31,8 @@ export default function createWrapperComponent(node, options = {}) {
       };
     },
 
-    setChildProps(props) {
+    setChildProps(newProps) {
+      const props = objectAssign({}, this.state.props, newProps);
       return new Promise(resolve => this.setState({ props }, resolve));
     },
 

src/__tests__/ReactWrapper-spec.js

@@ -259,6 +259,25 @@ describeWithDOM('mount', () => {
       expect(spy.calledWith(nextProps)).to.equal(true);
     });
 
+    it('should merge newProps with oldProps', () => {
+      class Foo extends React.Component {
+        render() {
+          return (
+            <div {...this.props} />
+          );
+        }
+      }
+
+      const wrapper = mount(<Foo a="a" b="b" />);
+      expect(wrapper.props().a).to.equal('a');
+      expect(wrapper.props().b).to.equal('b');
+
+      wrapper.setProps({ b: 'c', d: 'e' });
+      expect(wrapper.props().a).to.equal('a');
+      expect(wrapper.props().b).to.equal('c');
+      expect(wrapper.props().d).to.equal('e');
+    });
+
   });
 
   describe('.setContext(newContext)', () => {

src/__tests__/ShallowWrapper-spec.js

@@ -273,6 +273,25 @@ describe('shallow', () => {
       expect(spy.calledWith(nextProps)).to.equal(true);
     });
 
+    it('should merge newProps with oldProps', () => {
+      class Foo extends React.Component {
+        render() {
+          return (
+            <div {...this.props} />
+          );
+        }
+      }
+
+      const wrapper = shallow(<Foo a="a" b="b" />);
+      expect(wrapper.props().a).to.equal('a');
+      expect(wrapper.props().b).to.equal('b');
+
+      wrapper.setProps({ b: 'c', d: 'e' });
+      expect(wrapper.props().a).to.equal('a');
+      expect(wrapper.props().b).to.equal('c');
+      expect(wrapper.props().d).to.equal('e');
+    });
+
   });
 
   describe('.setContext(newContext)', () => {