Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to web3.js 1.0.0-beta.46 #751

Closed
schmidsi opened this issue Feb 6, 2019 · 4 comments
Closed

Update to web3.js 1.0.0-beta.46 #751

schmidsi opened this issue Feb 6, 2019 · 4 comments

Comments

@schmidsi
Copy link
Contributor

schmidsi commented Feb 6, 2019

There should be a lot of stability improvements. Unfortunately, the new TypeScript types create typing errors on our side. They are probably resolved fast.

@schmidsi
Copy link
Contributor Author

schmidsi commented Feb 6, 2019

Especially web-socket connections are buggy at the moment and an update should fix this. See web3/web3.js#1965 (comment)

@schmidsi schmidsi changed the title Update to web3.js 1.0.0-beta.41 Update to web3.js 1.0.0-beta.46 Feb 9, 2019
@schmidsi
Copy link
Contributor Author

schmidsi commented Feb 9, 2019

Check for latest release first: https://www.npmjs.com/package/web3

@Bowfish
Copy link

Bowfish commented Feb 12, 2019

When I run truffle migrate --network devilnet with the following network configuration:

devilnet: {
      websockets: true,        // Enable EventEmitter interface for web3 (default: false)
      provider: () => new Web3.providers.WebsocketProvider("ws://localhost:8546", {
        headers: {
          Origin: "127.0.0.1"
        }
})

I get the following error:

/home/xyz/node_modules/web3-providers/dist/web3-providers.cjs.js:304
event = this.getSubscriptionEvent(response.params.subscription);
                                                  ^
TypeError: Cannot read property 'subscription' of undefined
    at WebsocketProvider.onMessage (/home/xyz/src/bd300/client/node_modules/web3-providers/dist/web3-providers.cjs.js:242:59)
    at WebsocketProvider.onMessage (/home/xyz/src/bd300/client/node_modules/web3-providers/dist/web3-providers.cjs.js:378:77)
    at W3CWebSocket._dispatchEvent [as dispatchEvent] (/home/xyz/src/bd300/client/node_modules/yaeti/lib/EventTarget.js:115:12)
    at W3CWebSocket.onMessage (/home/xyz/src/bd300/client/node_modules/websocket/lib/W3CWebSocket.js:234:14)
    at WebSocketConnection.<anonymous> (/home/xyz/src/bd300/client/node_modules/websocket/lib/W3CWebSocket.js:205:19)
    at emitOne (events.js:116:13)
    at WebSocketConnection.emit (events.js:211:7)
    at WebSocketConnection.processFrame (/home/xyz/src/bd300/client/node_modules/websocket/lib/WebSocketConnection.js:552:26)
    at /home/xyz/src/bd300/client/node_modules/websocket/lib/WebSocketConnection.js:321:40
    at _combinedTickCallback (internal/process/next_tick.js:132:7)
    at process._tickCallback (internal/process/next_tick.js:181:9)

Environment

  • web3: web3.js 1.0.0-beta.46
  • Operating System: linux
  • Ethereum client: geth version 1.8.22-stable
  • Truffle version (truffle version): v5.0.3 (core: 5.0.3)
  • node version (node --version): 8.15.0
  • npm version (npm --version): 6.7.0

@schmidsi
Copy link
Contributor Author

Thanks for your input @Bowfish, but I don't understand the connection to this issue.

@travs travs closed this as completed Dec 10, 2019
SeanJCasey added a commit that referenced this issue Dec 17, 2021
* refactor: validate token pair ordering during external position init

* refactor: only approve token pair once for NFT manager

* refactor: remove unnecessary deadline calc

* chore: add helper to order Uniswap v3 pool tokens

* test: add coverage for Uniswap v3 liquidity init()

* fix: remove redundant storage assignment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants