Skip to content

Commit

Permalink
pkg/actuators/machine/actuator: Drop setMachineCloudProviderSpecifics…
Browse files Browse the repository at this point in the history
… comment

The updateProviderID comment was probably a copy/paste error when
setMachineCloudProviderSpecifics landed in 716083f (Set additional
machine annotations/labels to get pretty machine output, 2019-07-23,
openshift#242).  I haven't read through the
function carefully enough to be able to propose a comment that adds
much beyond the function name, which is fairly clear on its own.  But
I know the updateProviderID comment is not a good fit ;).
  • Loading branch information
wking authored and enxebre committed Feb 20, 2020
1 parent 1d28bb6 commit 9f07ffc
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pkg/actuators/machine/actuator.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ func (a *Actuator) Create(context context.Context, cluster *clusterv1.Cluster, m
return a.updateStatus(updatedMachine, instance)
}

// updateProviderID adds providerID in the machine spec
func (a *Actuator) setMachineCloudProviderSpecifics(machine *machinev1.Machine, instance *ec2.Instance) (*machinev1.Machine, error) {
if instance == nil {
return machine, nil
Expand Down

0 comments on commit 9f07ffc

Please sign in to comment.