Merge pull request #85402 from RainbowMango/pr_remove_metrics_hidden_log

Remove metric be hidden log temporarily
enxebre · Nov 22, 2019 · d87c921 · d87c921
2 parents 3c5dad6 + c22ffa2
commit d87c921
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/staging/src/k8s.io/component-base/metrics/desc.go b/staging/src/k8s.io/component-base/metrics/desc.go
@@ -119,7 +119,8 @@ func (d *Desc) determineDeprecationStatus(version semver.Version) {
 			return
 		}
 		if shouldHide(&version, selfVersion) {
-			klog.Warningf("This metric(%s) has been deprecated for more than one release, hiding.", d.fqName)
+			// TODO(RainbowMango): Remove this log temporarily. https://github.com/kubernetes/kubernetes/issues/85369
+			// klog.Warningf("This metric(%s) has been deprecated for more than one release, hiding.", d.fqName)
 			d.isHidden = true
 		}
 	})

diff --git a/staging/src/k8s.io/component-base/metrics/metric.go b/staging/src/k8s.io/component-base/metrics/metric.go
@@ -102,7 +102,8 @@ func (r *lazyMetric) determineDeprecationStatus(version semver.Version) {
 			return
 		}
 		if shouldHide(&version, selfVersion) {
-			klog.Warningf("This metric has been deprecated for more than one release, hiding.")
+			// TODO(RainbowMango): Remove this log temporarily. https://github.com/kubernetes/kubernetes/issues/85369
+			// klog.Warningf("This metric has been deprecated for more than one release, hiding.")
 			r.isHidden = true
 		}
 	})