Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swith to github.com/libp2p/go-reuseport #774

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Dec 1, 2024

alternative for #748

@arkodg
Copy link
Contributor

arkodg commented Dec 2, 2024

the motivation (my guess is) for using the reuseport package is to set SO_REUSEADDR & SO_REUSEPORT e.g.
https://github.com/libp2p/go-reuseport/blob/a3a76c79205aca3ed2bfd07c6c45f29e8cb0784d/control_unix.go

Since the existing package doesnt work well for binding to an ipv6 addr, my suggestion is to replace it with https://github.com/libp2p/go-reuseport or setup the listenConfig in this repo itself

cc @mattklein123 @collin-lee

@zirain zirain changed the title use net.Listen swith to github.com/libp2p/go-reuseport Dec 3, 2024
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@psbrar99 psbrar99 self-requested a review December 5, 2024 00:27
Copy link

@psbrar99 psbrar99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thanks.

@psbrar99 psbrar99 merged commit 1818d41 into envoyproxy:main Dec 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants