Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: run gofumpt #664

Merged
merged 2 commits into from
Aug 2, 2024
Merged

chore: run gofumpt #664

merged 2 commits into from
Aug 2, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Aug 2, 2024

No description provided.

zirain added 2 commits August 2, 2024 15:37
@zirain
chore: run gofumpt
d8f0783 
Signed-off-by: zirain <[email protected]>
@zirain
fix_format
f6049b9 
Signed-off-by: zirain <[email protected]>
mattklein123
mattklein123 approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to do this in CI and error on it if you can do that as a follow up?

@mattklein123 mattklein123 merged commit 803b65c into envoyproxy:main Aug 2, 2024
6 checks passed
@zirain
Copy link
Contributor Author

zirain commented Aug 3, 2024

will take a look at later

@zirain zirain deleted the gofumpt branch August 3, 2024 02:34
@zirain zirain mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklein123 mattklein123 mattklein123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zirain @mattklein123