Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly count redis active connection #312

Merged
merged 3 commits into from
Nov 26, 2021
Merged

Incorrectly count redis active connection #312

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e9fbf3
health check failed if no active redis connection
debbyku Nov 1, 2021
9f45865
Merge branch 'envoyproxy:main' into main
debbyku Nov 19, 2021
104c27b
solve redis connection active count error
debbyku Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/redis/driver_impl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,15 @@ func newPoolStats(scope stats.Scope) poolStats {

func poolTrace(ps *poolStats, healthCheckActiveConnection bool, srv server.Server) trace.PoolTrace {
return trace.PoolTrace{
ConnCreated: func(_ trace.PoolConnCreated) {
ps.connectionTotal.Add(1)
ps.connectionActive.Add(1)
if healthCheckActiveConnection && srv != nil {
srv.HealthCheckOK()
ConnCreated: func(newConn trace.PoolConnCreated) {
if newConn.Err == nil {
ps.connectionTotal.Add(1)
ps.connectionActive.Add(1)
if healthCheckActiveConnection && srv != nil {
srv.HealthCheckOK()
}
} else {
fmt.Println("creating redis connection error :", newConn.Err)
}
},
ConnClosed: func(_ trace.PoolConnClosed) {
Expand Down