Add support for SRV records for memcache clients #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have run this myself and confirmed it works, but there are elements I have struggled to lock down with unit tests, namely:
My knowledge of go is quite limited so I can happily add such tests if they are deemed necessary and I can get some pointers on how to do it :) |
|
Please merge main. /wait |
|
I have rebased ontop of main @mattklein123 |
petedmarsh
force-pushed
the
support-srv
branch
2 times, most recently
from
93ee03c to
5720fe0
Compare
petedmarsh
commented
May 26, 2021
src/settings/settings.go
Outdated
| @@ -62,7 +62,7 @@ type Settings struct { | |||
| RedisPerSecondPoolSize int `envconfig:"REDIS_PERSECOND_POOL_SIZE" default:"10"` | |||
| RedisPerSecondAuth string `envconfig:"REDIS_PERSECOND_AUTH" default:""` | |||
| RedisPerSecondTls bool `envconfig:"REDIS_PERSECOND_TLS" default:"false"` | |||
| // RedisPerSecondPipelineWindow sets the duration after which internal pipelines will be flushed for per second redis. | |||
| // RedisPerSec ondPipelineWindow sets the duration after which internal pipelines will be flushed for per second redis. | |||
This allows MEMCAHE_SRV to be specified as an SRV record from
which multiple memcache hosts can be resolved. For example:
MEMCACHE_SRV=_memcache._tcp.mylovelydomain.com
This can be used instead of MEMCACHE_HOST_PORT.
This will then be resolved and whatever set of servers it represents
will be used as the set of memcache servers to connect to. At this
stage neither priority or weight is supported, though weight could
be fairly straightforwardly in future.
The SRV can be polled periodically for new servers by setting the
following env var (with 0 meaning "never check"):
MEMCACHE_SRV_REFRESH=600s # supports standard go durations
Signed-off-by: Peter Marsh <[email protected]>
storozhukBM
pushed a commit
to storozhukBM/ratelimit-1
that referenced
this pull request
May 28, 2021
This allows MEMCAHE_SRV to be specified as an SRV record from
which multiple memcache hosts can be resolved. For example:
MEMCACHE_SRV=_memcache._tcp.mylovelydomain.com
This can be used instead of MEMCACHE_HOST_PORT.
This will then be resolved and whatever set of servers it represents
will be used as the set of memcache servers to connect to. At this
stage neither priority or weight is supported, though weight could
be fairly straightforwardly in future.
The SRV can be polled periodically for new servers by setting the
following env var (with 0 meaning "never check"):
MEMCACHE_SRV_REFRESH=600s # supports standard go durations
Signed-off-by: Peter Marsh <[email protected]>
storozhukBM
pushed a commit
to storozhukBM/ratelimit-1
that referenced
this pull request
May 28, 2021
This allows MEMCAHE_SRV to be specified as an SRV record from
which multiple memcache hosts can be resolved. For example:
MEMCACHE_SRV=_memcache._tcp.mylovelydomain.com
This can be used instead of MEMCACHE_HOST_PORT.
This will then be resolved and whatever set of servers it represents
will be used as the set of memcache servers to connect to. At this
stage neither priority or weight is supported, though weight could
be fairly straightforwardly in future.
The SRV can be polled periodically for new servers by setting the
following env var (with 0 meaning "never check"):
MEMCACHE_SRV_REFRESH=600s # supports standard go durations
Signed-off-by: Peter Marsh <[email protected]>
Signed-off-by: bstorozhuk <[email protected]>
zdmytriv
pushed a commit
to verygoodsecurity/ratelimit
that referenced
this pull request
Aug 2, 2021
This allows MEMCAHE_SRV to be specified as an SRV record from
which multiple memcache hosts can be resolved. For example:
MEMCACHE_SRV=_memcache._tcp.mylovelydomain.com
This can be used instead of MEMCACHE_HOST_PORT.
This will then be resolved and whatever set of servers it represents
will be used as the set of memcache servers to connect to. At this
stage neither priority or weight is supported, though weight could
be fairly straightforwardly in future.
The SRV can be polled periodically for new servers by setting the
following env var (with 0 meaning "never check"):
MEMCACHE_SRV_REFRESH=600s # supports standard go durations
Signed-off-by: Peter Marsh <[email protected]>
timcovar
pushed a commit
to goatapp/ratelimit
that referenced
this pull request
Jan 16, 2024
This allows MEMCAHE_SRV to be specified as an SRV record from
which multiple memcache hosts can be resolved. For example:
MEMCACHE_SRV=_memcache._tcp.mylovelydomain.com
This can be used instead of MEMCACHE_HOST_PORT.
This will then be resolved and whatever set of servers it represents
will be used as the set of memcache servers to connect to. At this
stage neither priority or weight is supported, though weight could
be fairly straightforwardly in future.
The SRV can be polled periodically for new servers by setting the
following env var (with 0 meaning "never check"):
MEMCACHE_SRV_REFRESH=600s # supports standard go durations
Signed-off-by: Peter Marsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows MEMCAHE_SRV to be specified as an SRV record from
which multiple memcache hosts can be resolved. For example:
This can be used instead of MEMCACHE_HOST_PORT.
This will then be resolved and whatever set of servers it represents
will be used as the set of memcache servers to connect to. At this
stage neither priority or weight is supported, though weight could
be fairly straightforwardly in future.
The SRV can be polled periodically for new servers by setting the
following env var (with 0 meaning "never check"):