Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a Dockerfile for running integration tests #156

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Introduce a Dockerfile for running integration tests #156

merged 2 commits into from
Jul 13, 2020

Commits on Jul 8, 2020

  1. Introduce a Dockerfile for running integration tests 

    This diff creates Dockerfile.integration for running integration tests with clearly-defined dependencies. Previously the dependencies of the integration tests were defined within the github actions config.

The new "make docker_tests" target should work for any developer with Docker installed.

Previously there was no single command that would run integration tests across platforms, which makes development and onboarding harder. Even copying the command from github actions wouldn't have worked before, since that command quietly assumed that redis was already running on port 6379.

Signed-off-by: David Weitzman <[email protected]>
    @dweitzman
    dweitzman committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    b71dade View commit details
    Browse the repository at this point in the history

  2. Support non-TTY with "make docker_tests" 

    Signed-off-by: David Weitzman <[email protected]>
    @dweitzman
    dweitzman committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    9aed3bd View commit details
    Browse the repository at this point in the history