Skip to content

address comments

Codecov / codecov/patch failed Oct 20, 2023 in 1s

51.66% of diff hit (target 60.00%)

View this Pull Request on Codecov

51.66% of diff hit (target 60.00%)

Annotations

Check warning on line 344 in internal/ir/xds.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/ir/xds.go#L336-L344

Added lines #L336 - L344 were not covered by tests

Check warning on line 346 in internal/ir/xds.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/ir/xds.go#L346

Added line #L346 was not covered by tests

Check warning on line 463 in internal/ir/xds.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/ir/xds.go#L461-L463

Added lines #L461 - L463 were not covered by tests

Check warning on line 91 in internal/ir/zz_generated.deepcopy.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/ir/zz_generated.deepcopy.go#L81-L91

Added lines #L81 - L91 were not covered by tests

Check warning on line 113 in internal/ir/zz_generated.deepcopy.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/ir/zz_generated.deepcopy.go#L94-L113

Added lines #L94 - L113 were not covered by tests

Check warning on line 123 in internal/ir/zz_generated.deepcopy.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/ir/zz_generated.deepcopy.go#L117-L123

Added lines #L117 - L123 were not covered by tests

Check warning on line 438 in internal/ir/zz_generated.deepcopy.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/ir/zz_generated.deepcopy.go#L435-L438

Added lines #L435 - L438 were not covered by tests

Check warning on line 30 in internal/xds/translator/cors.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/xds/translator/cors.go#L29-L30

Added lines #L29 - L30 were not covered by tests

Check warning on line 34 in internal/xds/translator/cors.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/xds/translator/cors.go#L33-L34

Added lines #L33 - L34 were not covered by tests

Check warning on line 46 in internal/xds/translator/cors.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/xds/translator/cors.go#L42-L46

Added lines #L42 - L46 were not covered by tests

Check warning on line 52 in internal/xds/translator/cors.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/xds/translator/cors.go#L51-L52

Added lines #L51 - L52 were not covered by tests

Check warning on line 67 in internal/xds/translator/cors.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/xds/translator/cors.go#L66-L67

Added lines #L66 - L67 were not covered by tests

Check warning on line 82 in internal/xds/translator/cors.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/xds/translator/cors.go#L81-L82

Added lines #L81 - L82 were not covered by tests

Check warning on line 98 in internal/xds/translator/cors.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/xds/translator/cors.go#L97-L98

Added lines #L97 - L98 were not covered by tests

Check warning on line 101 in internal/xds/translator/cors.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/xds/translator/cors.go#L100-L101

Added lines #L100 - L101 were not covered by tests

Check warning on line 111 in internal/xds/translator/cors.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/xds/translator/cors.go#L108-L111

Added lines #L108 - L111 were not covered by tests

Check warning on line 136 in internal/xds/translator/cors.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/xds/translator/cors.go#L132-L136

Added lines #L132 - L136 were not covered by tests

Check warning on line 151 in internal/xds/translator/cors.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/xds/translator/cors.go#L146-L151

Added lines #L146 - L151 were not covered by tests

Check warning on line 173 in internal/xds/translator/cors.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/xds/translator/cors.go#L172-L173

Added lines #L172 - L173 were not covered by tests

Check warning on line 88 in internal/xds/translator/httpfilters.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/xds/translator/httpfilters.go#L87-L88

Added lines #L87 - L88 were not covered by tests

Check warning on line 93 in internal/xds/translator/httpfilters.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/xds/translator/httpfilters.go#L92-L93

Added lines #L92 - L93 were not covered by tests

Check warning on line 88 in internal/xds/translator/route.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/xds/translator/route.go#L87-L88

Added lines #L87 - L88 were not covered by tests