tracing: support SamplingFraction #5125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5125 +/- ##
==========================================
- Coverage 66.89% 66.87% -0.02%
==========================================
Files 210 210
Lines 32984 32995 +11
==========================================
+ Hits 22064 22065 +1
- Misses 9584 9590 +6
- Partials 1336 1340 +4 ☔ View full report in Codecov by Sentry. |
zirain
commented
Jan 23, 2025
| @@ -4,7 +4,7 @@ RELEASE_VERSIONS ?= $(foreach v,$(wildcard ${ROOT_DIR}/docs/*),$(notdir ${v})) | |||
| # find a way to remove github.com from ignore list | |||
| # TODO: example.com is not a valid domain, we should remove it from ignore list | |||
| # TODO: https://www.gnu.org/software/make became unstable, we should remove it from ignore list later | |||
| LINKINATOR_IGNORE := "github.com githubusercontent.com example.com github.io gnu.org _print" | |||
| LINKINATOR_IGNORE := "github.com jwt.io githubusercontent.com example.com github.io gnu.org _print" | |||
There was a problem hiding this comment.
not sure about why following happen:
[500] https://jwt.io/
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
arkodg
approved these changes
Jan 23, 2025
zhaohuabing
approved these changes
Jan 23, 2025
DeeBi9
pushed a commit
to DeeBi9/gateway
that referenced
this pull request
Jan 25, 2025
* tracing: support SamplingFraction Signed-off-by: zirain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5089