-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support patching on EnvoyProxy.spec.provider.kubernetes.envoyHpa and EnvoyProxy.spec.provider.kubernetes.envoyPDB #4910
Conversation
Signed-off-by: keithfz <[email protected]>
Signed-off-by: keithfz <[email protected]>
Signed-off-by: keithfz <[email protected]>
Signed-off-by: keithfz <[email protected]>
Signed-off-by: keithfz <[email protected]>
Signed-off-by: keithfz <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4910 +/- ##
==========================================
- Coverage 66.28% 66.26% -0.03%
==========================================
Files 209 209
Lines 31942 32035 +93
==========================================
+ Hits 21172 21227 +55
- Misses 9517 9546 +29
- Partials 1253 1262 +9 ☔ View full report in Codecov by Sentry. |
Signed-off-by: keithfz <[email protected]>
Signed-off-by: keithfz <[email protected]>
bleh - apologies on the lint stuff, first time working in this repo 😄 |
np thanks for the quick PR, will try and review this by EOD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
What type of PR is this?
This is an enhancement to enable a
patch
option forEnvoyProxy.spec.provider.kubernetes.envoyHpa
andEnvoyProxy.spec.provider.kubernetes.envoyPDB
in the EnvoyProxy API.What this PR does / why we need it:
This PR adds a
patch
field forEnvoyProxy.spec.provider.kubernetes.envoyHpa
andEnvoyProxy.spec.provider.kubernetes.envoyPDB
. To apply the patch, we use the same mechanism that we use for patching other resources in the EnvoyProxy API, such asenvoyDeployment
,envoyDaemonSet
, andenvoyService
.Which issue(s) this PR fixes:
Fixes #4894
Release Notes: Yes