ci: enable ipv6 test #4853
Merged
ci: enable ipv6 test #4853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4853 +/- ##
==========================================
- Coverage 66.09% 66.04% -0.05%
==========================================
Files 209 209
Lines 31890 31890
==========================================
- Hits 21077 21062 -15
- Misses 9571 9582 +11
- Partials 1242 1246 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zirain <[email protected]>
zirain
force-pushed
the
ipv6-enable-sed
branch
from
47912a3 to
3449688
Compare
zirain
commented
Dec 5, 2024
| @@ -16,6 +16,7 @@ metadata: | |||
| name: proxy-config | |||
| namespace: envoy-gateway-system | |||
| spec: | |||
| ipFamily: IPv4 | |||
There was a problem hiding this comment.
IpFamily needs to be set explicitly, sed will change it to right value.
There was a problem hiding this comment.
Nit: use {IP_FAMILY} instead of IPv4 to make it clearer?
There was a problem hiding this comment.
use IPv4 directly allow you apply this file without run make prepare-ip-family for debugging
arkodg
approved these changes
Dec 5, 2024
zhaohuabing
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.