fix license check #4821
Merged
fix license check #4821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4821 +/- ##
==========================================
- Coverage 65.59% 65.58% -0.01%
==========================================
Files 211 211
Lines 31999 31999
==========================================
- Hits 20990 20987 -3
- Misses 9765 9768 +3
Partials 1244 1244 ☔ View full report in Codecov by Sentry. |
zhaohuabing
force-pushed
the
fix-license-check
branch
from
2b02006 to
6a7bec1
Compare
Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing
force-pushed
the
fix-license-check
branch
from
6a7bec1 to
dd0522c
Compare
|
hey @zhaohuabing what's the issue here ? |
https://github.com/envoyproxy/gateway/actions/runs/12093687620/job/33724945952 https://github.com/envoyproxy/gateway/actions/runs/12097760780/job/33733999207?pr=4822 The version must match the one listed on https://pkg.go.dev/github.com/golang/groupcache to pass the license check. |
zirain
previously approved these changes
Dec 1, 2024
Signed-off-by: Huabing Zhao <[email protected]>
arkodg
approved these changes
Dec 2, 2024
zirain
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the latest commit of github.com/golang/groupcache to fix the license check.