Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translator): ext-proc attributes #4796

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Nov 28, 2024

What type of PR is this?

What this PR does / why we need it:
Implements API from #4794

Which issue(s) this PR fixes:

relates #3170

Release Notes: Yes (in API PR)

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.60%. Comparing base (221bb50) to head (0fd1e88).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4796      +/-   ##
==========================================
- Coverage   65.63%   65.60%   -0.03%     
==========================================
  Files         211      211              
  Lines       31999    32015      +16     
==========================================
+ Hits        21002    21004       +2     
- Misses       9757     9766       +9     
- Partials     1240     1245       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guydc guydc marked this pull request as ready for review December 2, 2024 22:59
@guydc guydc requested a review from a team as a code owner December 2, 2024 22:59
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@zirain zirain merged commit b890071 into envoyproxy:main Dec 3, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants