fix: btlsp section name doesn't support port name #4784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
changed the title
zhaohuabing
changed the title
zhaohuabing
force-pushed
the
fix-btlsp-section-name
branch
from
153fd00 to
454d292
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4784 +/- ##
==========================================
+ Coverage 66.27% 66.31% +0.04%
==========================================
Files 209 209
Lines 31901 31912 +11
==========================================
+ Hits 21142 21163 +21
+ Misses 9510 9503 -7
+ Partials 1249 1246 -3 ☔ View full report in Codecov by Sentry. |
zhaohuabing
force-pushed
the
fix-btlsp-section-name
branch
from
454d292 to
97289e5
Compare
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing
force-pushed
the
fix-btlsp-section-name
branch
from
19a4814 to
1536c2a
Compare
zhaohuabing
commented
Nov 26, 2024
arkodg
reviewed
Nov 27, 2024
arkodg
reviewed
Nov 27, 2024
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing
force-pushed
the
fix-btlsp-section-name
branch
from
299e3fe to
1c829ce
Compare
Signed-off-by: Huabing Zhao <[email protected]>
zirain
previously approved these changes
Dec 5, 2024
Signed-off-by: Huabing Zhao <[email protected]>
zirain
approved these changes
Dec 6, 2024
arkodg
approved these changes
Dec 6, 2024
zhaohuabing
added a commit
to zhaohuabing/gateway
that referenced
this pull request
Dec 13, 2024
* fix btlsp section name Signed-off-by: Huabing Zhao <[email protected]> * add release note Signed-off-by: Huabing Zhao <[email protected]> * optmize service search Signed-off-by: Huabing Zhao <[email protected]> * address comment Signed-off-by: Huabing Zhao <[email protected]> * fix test Signed-off-by: Huabing Zhao <[email protected]> * fix test Signed-off-by: Huabing Zhao <[email protected]> * address comment Signed-off-by: Huabing Zhao <[email protected]> * fix e2e Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> (cherry picked from commit b9f9a9f) Signed-off-by: Huabing Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4769
This PR uses port name as the
sectionNamefor the targetRefs of theBackendTLSPolicy.Release Notes: Yes