Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: use Cluster_AUTO DnsLookupFamily #4740

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Conversation

zirain
Copy link
Member

@zirain zirain commented Nov 19, 2024

fixes: #4605

@zirain zirain requested a review from a team as a code owner November 19, 2024 09:17
@zirain
Copy link
Member Author

zirain commented Nov 19, 2024

test passed on #4690

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.66%. Comparing base (86d750a) to head (5251bed).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/xds/translator/cluster.go 11.11% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4740      +/-   ##
==========================================
+ Coverage   65.63%   65.66%   +0.03%     
==========================================
  Files         211      211              
  Lines       31996    32001       +5     
==========================================
+ Hits        21000    21013      +13     
+ Misses       9757     9752       -5     
+ Partials     1239     1236       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@zirain zirain requested a review from arkodg November 20, 2024 02:17
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@arkodg arkodg requested review from a team November 20, 2024 03:07
@zirain zirain merged commit a924cec into envoyproxy:main Nov 20, 2024
23 of 24 checks passed
@zirain zirain deleted the dns-cluster-auto branch November 20, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster_V4_ONLY cause no healthy upstream on IPv6 first cluster
3 participants