Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: skip some test on IPv6/non-dual #4726

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

zirain
Copy link
Member

@zirain zirain commented Nov 15, 2024

for RateLimit tests, it's because of

            - sourceCIDR:
                value: 0.0.0.0/0
                type: Distinct

Signed-off-by: zirain <[email protected]>
@zirain zirain requested a review from a team as a code owner November 15, 2024 13:00
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.58%. Comparing base (c9ae045) to head (5000880).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4726      +/-   ##
==========================================
- Coverage   65.60%   65.58%   -0.03%     
==========================================
  Files         211      211              
  Lines       31998    31998              
==========================================
- Hits        20993    20986       -7     
- Misses       9764     9768       +4     
- Partials     1241     1244       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arkodg
arkodg previously approved these changes Nov 15, 2024
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@arkodg arkodg requested review from a team November 15, 2024 13:09
Signed-off-by: zirain <[email protected]>
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@arkodg arkodg merged commit 0f68219 into envoyproxy:main Nov 15, 2024
24 checks passed
@zirain zirain deleted the skip-test branch November 15, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants