Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove container's ports field #4714

Merged

Conversation

kebe7jun
Copy link
Contributor

@kebe7jun kebe7jun commented Nov 14, 2024

What type of PR is this?

fix: remove container's ports field

What this PR does / why we need it:

Fllow #4712

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes

@kebe7jun kebe7jun requested a review from a team as a code owner November 14, 2024 04:53
@kebe7jun kebe7jun force-pushed the feat/disableListenerContainerPort branch from 8ec59ac to 996a503 Compare November 14, 2024 04:54
@kebe7jun kebe7jun changed the title Add disableListenerContainerPort field for the EnvoyProxy feat: add disableListenerContainerPort field for the EnvoyProxy Nov 14, 2024
@kebe7jun kebe7jun force-pushed the feat/disableListenerContainerPort branch 2 times, most recently from d2be7df to 10e5730 Compare November 19, 2024 08:24
@kebe7jun kebe7jun changed the title feat: add disableListenerContainerPort field for the EnvoyProxy fix: remove container's ports field Nov 19, 2024
@arkodg
Copy link
Contributor

arkodg commented Nov 20, 2024

@kebe7jun you'll need to run make generate and make testdata to update the tests

@kebe7jun kebe7jun force-pushed the feat/disableListenerContainerPort branch from 10e5730 to 0e501e3 Compare November 20, 2024 02:47
@kebe7jun kebe7jun force-pushed the feat/disableListenerContainerPort branch from 0e501e3 to b6a2f13 Compare November 20, 2024 02:47
@kebe7jun
Copy link
Contributor Author

@kebe7jun you'll need to run make generate and make testdata to update the tests

Thank you, updated.

@arkodg arkodg requested review from a team November 20, 2024 03:06
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.63%. Comparing base (86d750a) to head (b6a2f13).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4714      +/-   ##
==========================================
- Coverage   65.63%   65.63%   -0.01%     
==========================================
  Files         211      211              
  Lines       31996    31979      -17     
==========================================
- Hits        21000    20988      -12     
+ Misses       9757     9752       -5     
  Partials     1239     1239              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@zhaohuabing zhaohuabing merged commit 950dde6 into envoyproxy:main Nov 20, 2024
23 of 24 checks passed
@kebe7jun kebe7jun deleted the feat/disableListenerContainerPort branch November 20, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants