Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: net.JoinHostPort #4692

Merged
merged 1 commit into from
Nov 11, 2024
Merged

chore: net.JoinHostPort #4692

merged 1 commit into from
Nov 11, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented Nov 10, 2024

No description provided.

@zirain zirain requested a review from a team as a code owner November 10, 2024 15:37
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.58%. Comparing base (2c98617) to head (f19cee1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4692      +/-   ##
==========================================
+ Coverage   65.53%   65.58%   +0.05%     
==========================================
  Files         211      211              
  Lines       31954    31954              
==========================================
+ Hits        20941    20957      +16     
+ Misses       9770     9756      -14     
+ Partials     1243     1241       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg arkodg requested review from a team November 10, 2024 17:22
@zirain zirain merged commit a7d6526 into envoyproxy:main Nov 11, 2024
24 checks passed
@zirain zirain deleted the net-join branch November 11, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants