Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dnsSearch on kind cluster #4691

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

zirain
Copy link
Member

@zirain zirain commented Nov 10, 2024

xref: #4572

@zirain zirain requested a review from a team as a code owner November 10, 2024 15:34
@zirain zirain mentioned this pull request Nov 10, 2024
7 tasks
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.55%. Comparing base (2c98617) to head (7f03d07).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4691      +/-   ##
==========================================
+ Coverage   65.53%   65.55%   +0.01%     
==========================================
  Files         211      211              
  Lines       31954    31954              
==========================================
+ Hits        20941    20946       +5     
+ Misses       9770     9767       -3     
+ Partials     1243     1241       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Member Author

zirain commented Nov 10, 2024

nslookup worked as excepted:

k exec -it deployments/dnsutils -- nslookup sleep.default.svc.cluster.local
Server:		fd00:10:96::a
Address:	fd00:10:96::a#53

Name:	sleep.default.svc.cluster.local
Address: fd00:10:96::1d41

k exec -it deployments/dnsutils -- cat /etc/resolv.conf
search default.svc.cluster.local svc.cluster.local cluster.local
nameserver fd00:10:96::a
options ndots:5

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team November 10, 2024 17:24
@zirain zirain merged commit ec56a83 into envoyproxy:main Nov 11, 2024
24 checks passed
@zirain zirain deleted the kind/dnsSearch branch November 11, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants