Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add body to ext auth #4671

Merged
merged 17 commits into from
Dec 5, 2024

Conversation

AurelienPillevesse
Copy link
Contributor

What type of PR is this?
Add gesture for body to ext auth

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #4431

@AurelienPillevesse AurelienPillevesse requested a review from a team as a code owner November 7, 2024 12:36
Signed-off-by: Aurélien Pillevesse <[email protected]>
Signed-off-by: Aurélien Pillevesse <[email protected]>
@AurelienPillevesse
Copy link
Contributor Author

The testing part (https://gateway.envoyproxy.io/contributions/develop/#testing) seems not to work on my computer so I tried to modify internal/gatewayapi/testdata/securitypolicy-with-extauth-backend.in.yaml and internal/gatewayapi/testdata/securitypolicy-with-extauth-backend.out.yaml manually and hope that it will pass.

Don't really know how to do it better.

@zirain
Copy link
Contributor

zirain commented Nov 7, 2024

it would be good to send API first.

@AurelienPillevesse
Copy link
Contributor Author

From api/ or internal/gatewayapi/ or both ?

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.27%. Comparing base (3074800) to head (f28348d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4671      +/-   ##
==========================================
+ Coverage   66.09%   66.27%   +0.18%     
==========================================
  Files         209      209              
  Lines       31890    31901      +11     
==========================================
+ Hits        21077    21142      +65     
+ Misses       9571     9510      -61     
- Partials     1242     1249       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Aurélien Pillevesse <[email protected]>
Signed-off-by: Aurélien Pillevesse <[email protected]>
Signed-off-by: Aurélien Pillevesse <[email protected]>
@zhaohuabing
Copy link
Member

cc @guydc

@zhaohuabing zhaohuabing requested a review from guydc November 19, 2024 09:44
Signed-off-by: Aurélien Pillevesse <[email protected]>
Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me, just one comment on the docs and please rebase + fix test code generation

api/v1alpha1/ext_auth_types.go Show resolved Hide resolved
Signed-off-by: Aurélien Pillevesse <[email protected]>
Signed-off-by: Aurélien Pillevesse <[email protected]>
guydc
guydc previously approved these changes Dec 3, 2024
Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Signed-off-by: Aurélien Pillevesse <[email protected]>
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team December 5, 2024 17:30
@arkodg arkodg merged commit ac86045 into envoyproxy:main Dec 5, 2024
27 checks passed
@AurelienPillevesse AurelienPillevesse deleted the add-body-to-ext-auth branch December 6, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for with_request_body in SecurityPolicy.spec.extAuth
6 participants