-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add body to ext auth #4671
feat: add body to ext auth #4671
Conversation
Signed-off-by: Aurélien Pillevesse <[email protected]>
Signed-off-by: Aurélien Pillevesse <[email protected]>
497ebb8
to
574815d
Compare
The testing part (https://gateway.envoyproxy.io/contributions/develop/#testing) seems not to work on my computer so I tried to modify Don't really know how to do it better. |
it would be good to send API first. |
From |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4671 +/- ##
==========================================
+ Coverage 66.09% 66.27% +0.18%
==========================================
Files 209 209
Lines 31890 31901 +11
==========================================
+ Hits 21077 21142 +65
+ Misses 9571 9510 -61
- Partials 1242 1249 +7 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Aurélien Pillevesse <[email protected]>
528f373
to
9f63579
Compare
Signed-off-by: Aurélien Pillevesse <[email protected]>
c8baa00
to
3bd62e3
Compare
Signed-off-by: Aurélien Pillevesse <[email protected]>
Signed-off-by: Aurélien Pillevesse <[email protected]>
34067fd
to
1b6eb87
Compare
cc @guydc |
Signed-off-by: Aurélien Pillevesse <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good to me, just one comment on the docs and please rebase + fix test code generation
Signed-off-by: Aurélien Pillevesse <[email protected]>
Signed-off-by: Aurélien Pillevesse <[email protected]>
Signed-off-by: Aurélien Pillevesse <[email protected]>
Signed-off-by: Aurélien Pillevesse <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Signed-off-by: Aurélien Pillevesse <[email protected]>
e012b56
to
c04e8c3
Compare
Signed-off-by: Aurélien Pillevesse <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
What type of PR is this?
Add gesture for body to ext auth
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4431