Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update release process #4665

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Conversation

zhaohuabing
Copy link
Member

Update the release process to incoroporate some lessons that I have learned during the v1.2.0 release.

Release Note: No

@zhaohuabing zhaohuabing requested a review from a team as a code owner November 7, 2024 07:04
@zhaohuabing zhaohuabing marked this pull request as draft November 7, 2024 07:04
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.62%. Comparing base (78da42c) to head (336b3ee).
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4665   +/-   ##
=======================================
  Coverage   65.61%   65.62%           
=======================================
  Files         211      211           
  Lines       31961    31961           
=======================================
+ Hits        20972    20973    +1     
+ Misses       9751     9749    -2     
- Partials     1238     1239    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing zhaohuabing force-pushed the update-release-process branch 2 times, most recently from 5a8f118 to 1c3fe30 Compare November 7, 2024 08:30
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing zhaohuabing force-pushed the update-release-process branch from 1c3fe30 to 46e3e05 Compare November 7, 2024 08:32
@zhaohuabing zhaohuabing marked this pull request as ready for review November 7, 2024 08:33
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing zhaohuabing force-pushed the update-release-process branch from 6e4a418 to 749a1b3 Compare November 21, 2024 04:35
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one small nit.

site/content/en/contributions/RELEASING.md Show resolved Hide resolved
site/content/en/contributions/RELEASING.md Show resolved Hide resolved
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@arkodg arkodg requested review from a team November 27, 2024 19:47
@zhaohuabing zhaohuabing merged commit f8f74b7 into envoyproxy:main Nov 28, 2024
26 of 27 checks passed
@zhaohuabing zhaohuabing deleted the update-release-process branch November 28, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants