Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: unhide cookiedomain for OIDC #4653

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

zhaohuabing
Copy link
Member

Remove notImplementedHide for CookieDomain as it's already implemented.
Release Notes: No

Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing zhaohuabing requested a review from a team as a code owner November 7, 2024 01:30
@arkodg arkodg requested review from a team November 7, 2024 01:35
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@44408dd). Learn more about missing BASE report.
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4653   +/-   ##
=======================================
  Coverage        ?   65.56%           
=======================================
  Files           ?      211           
  Lines           ?    31945           
  Branches        ?        0           
=======================================
  Hits            ?    20945           
  Misses          ?     9757           
  Partials        ?     1243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing zhaohuabing merged commit 6458ae9 into envoyproxy:main Nov 7, 2024
25 of 27 checks passed
@zhaohuabing zhaohuabing deleted the unhide-cookiedomain branch November 7, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants