Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dump #4593

Merged
merged 1 commit into from
Oct 31, 2024
Merged

chore: remove dump #4593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions test/e2e/tests/oidc-backendcluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,14 @@ func init() {
ConformanceTests = append(ConformanceTests, OIDCBackendClusterTest)
}

// OIDCTest tests OIDC authentication for an http route with OIDC configured.
// OIDCBackendClusterTest tests OIDC authentication for an http route with OIDC configured.
// The http route points to an application to verify that OIDC authentication works on application/http path level.
var OIDCBackendClusterTest = suite.ConformanceTest{
ShortName: "OIDC with BackendCluster",
Description: "Test OIDC authentication",
Manifests: []string{"testdata/oidc-keycloak.yaml", "testdata/oidc-securitypolicy-backendcluster.yaml"},
Test: func(t *testing.T, suite *suite.ConformanceTestSuite) {
t.Run("oidc provider represented by a BackendCluster", func(t *testing.T) {
// Add a function to dump current cluster status
t.Cleanup(func() {
CollectAndDump(t, suite.RestConfig)
})

testOIDC(t, suite)
})
},
Expand Down
5 changes: 0 additions & 5 deletions test/e2e/tests/oidc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@ var OIDCTest = suite.ConformanceTest{
Manifests: []string{"testdata/oidc-keycloak.yaml", "testdata/oidc-securitypolicy.yaml"},
Test: func(t *testing.T, suite *suite.ConformanceTestSuite) {
t.Run("oidc provider represented by a URL", func(t *testing.T) {
// Add a function to dump current cluster status
t.Cleanup(func() {
CollectAndDump(t, suite.RestConfig)
})

testOIDC(t, suite)
})

Expand Down