Docs: fix incorrect namespace mention #4563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The namespace is incorrect Signed-off-by: Joost Naaijen <[email protected]>
Signed-off-by: Joost Naaijen <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4563 +/- ##
=======================================
Coverage ? 65.49%
=======================================
Files ? 211
Lines ? 31858
Branches ? 0
=======================================
Hits ? 20865
Misses ? 9751
Partials ? 1242 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Joost Naaijen <[email protected]>
arkodg
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs mention the wrong namespace for annotations. The namespace is set here I think: https://github.com/guydc/gateway/blob/e54b00f4e227e0e7d65bc6dbecf5b6d1f991dd7e/internal/gatewayapi/route.go#L35
It might be that i misunderstood the documentation and i'm mixing things up. If so, ill be happy to write a separate section with this example.
What type of PR is this?
Small correction to the docs.
What this PR does / why we need it:
It adds the correct namespace, and a small example of how to use it.
Which issue(s) this PR fixes:
Release Notes: No