refactor: safeset for controller cache resource. #4528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qicz <[email protected]>
Signed-off-by: qicz <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4528 +/- ##
==========================================
- Coverage 65.72% 65.70% -0.02%
==========================================
Files 211 212 +1
Lines 31669 31688 +19
==========================================
+ Hits 20813 20822 +9
- Misses 9656 9665 +9
- Partials 1200 1201 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: qicz <[email protected]>
Signed-off-by: qicz <[email protected]>
|
/retest |
|
@qicz can you elaborate the issue in the description |
zirain
reviewed
Oct 26, 2024
Signed-off-by: qicz <[email protected]>
done |
Signed-off-by: qicz <[email protected]>
Signed-off-by: qicz <[email protected]>
zirain
reviewed
Oct 26, 2024
| Values sets.Set[T] | ||
| } | ||
|
|
||
| func NewSafeSet[T comparable](items ...T) *SafeSet[T] { |
There was a problem hiding this comment.
Suggested change
| func NewSafeSet[T comparable](items ...T) *SafeSet[T] { | |
| func New[T comparable](items ...T) *SafeSet[T] { |
zirain
reviewed
Oct 26, 2024
|
|
||
| type SafeSet[T comparable] struct { | ||
| lock sync.RWMutex | ||
| Values sets.Set[T] |
|
@qicz can you share more details about why we need a lock here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Following #4454, optimize the resources cached with the safety set.
Release Notes: Yes/No