Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor byNamespaceSelectorEnabled #4513

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented Oct 24, 2024

make it easier to understand

@zirain zirain requested a review from a team as a code owner October 24, 2024 09:11
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.66%. Comparing base (9353be2) to head (229890e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4513      +/-   ##
==========================================
+ Coverage   65.60%   65.66%   +0.05%     
==========================================
  Files         210      210              
  Lines       31612    31618       +6     
==========================================
+ Hits        20739    20761      +22     
+ Misses       9670     9657      -13     
+ Partials     1203     1200       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg arkodg merged commit c24ceb1 into envoyproxy:main Oct 24, 2024
23 of 24 checks passed
@zirain zirain deleted the rewrite/byNamespaceSelectorEnabled branch October 24, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants