Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: share UnitToDuration logic #4510

Merged
merged 2 commits into from
Oct 24, 2024
Merged

chore: share UnitToDuration logic #4510

merged 2 commits into from
Oct 24, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented Oct 24, 2024

xref: #4495

@zirain zirain requested a review from a team as a code owner October 24, 2024 06:29
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.60%. Comparing base (9353be2) to head (df7b07b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/utils/ratelimit/unit.go 88.88% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4510   +/-   ##
=======================================
  Coverage   65.60%   65.60%           
=======================================
  Files         210      211    +1     
  Lines       31612    31602   -10     
=======================================
- Hits        20739    20733    -6     
+ Misses       9670     9666    -4     
  Partials     1203     1203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zirain <[email protected]>
@arkodg arkodg merged commit bc3df03 into envoyproxy:main Oct 24, 2024
24 checks passed
@zirain zirain deleted the chore branch October 24, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants