Reduce the amount of configuration logging, and make it line-delimeted friendly #4505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Anderson <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4505 +/- ##
==========================================
- Coverage 65.72% 65.68% -0.04%
==========================================
Files 211 211
Lines 31669 31676 +7
==========================================
- Hits 20813 20806 -7
- Misses 9656 9669 +13
- Partials 1200 1201 +1 ☔ View full report in Codecov by Sentry. |
|
#4506 adds coverage for the Xds |
arkodg
reviewed
Oct 25, 2024
| @@ -173,7 +173,9 @@ func (r *Runner) subscribeAndTranslate(ctx context.Context) { | |||
| // Publish the IRs. | |||
| // Also validate the ir before sending it. | |||
| for key, val := range result.InfraIR { | |||
| r.Logger.WithValues("infra-ir", key).Info(val.JSONString()) | |||
There was a problem hiding this comment.
shouldnt this be changed to .Debug ? and they won't show up because the default logging is Info
gateway/api/v1alpha1/envoygateway_helpers.go
Line 115 in 6f5ae8e
cc @zirain
There was a problem hiding this comment.
r.Logger embeds a logr.Logger. That interface doesn't believe in named levels beyond Info() and Error(), but it supports arbitrary levels of verbosity with V().
There was a problem hiding this comment.
yeah, that's right. there's no Debug in logr.Logger
There was a problem hiding this comment.
| level | description |
|---|---|
| v=0 | Generally useful for this to always be visible to a cluster operator. |
| v=1 | A reasonable default log level if you don’t want verbosity. |
| v=2 | Useful steady state information about the service and important log messages that may correlate to significant changes in the system.This is the recommended default log level for most systems. |
| v=3 | Extended information about changes. |
| v=4 | Debug level verbosity. |
| v=5 | Trace level verbosity. |
| v=6 | Display requested resources. |
| v=7 | Display HTTP request headers. |
| v=8 | Display HTTP request contents. |
| v=9 | Display HTTP request contents without truncation of contents. |
if we want something like debug, should change the level to 4.
There was a problem hiding this comment.
I'm happy to switch this to 4; it was previously always-on, so I wasn't sure how much it should be hidden, but 4 makes sense to me.
zirain
reviewed
Oct 26, 2024
zirain
reviewed
Oct 26, 2024
Signed-off-by: Evan Anderson <[email protected]> Signed-off-by: Evan Anderson <[email protected]>
evankanderson
force-pushed
the
terse-logging
branch
from
8d1bed7 to
596ccb6
Compare
zirain
approved these changes
Oct 26, 2024
zhaohuabing
pushed a commit
to zhaohuabing/gateway
that referenced
this pull request
Oct 29, 2024
…d friendly (envoyproxy#4505) * Reduce the amount and style of configuration logging Signed-off-by: Evan Anderson <[email protected]> * Update verbosity from 1->4 Signed-off-by: Evan Anderson <[email protected]> Signed-off-by: Evan Anderson <[email protected]> --------- Signed-off-by: Evan Anderson <[email protected]> Signed-off-by: Evan Anderson <[email protected]> (cherry picked from commit 7897fc5) Signed-off-by: Huabing Zhao <[email protected]>
evankanderson
added a commit
to evankanderson/gateway
that referenced
this pull request
Oct 29, 2024
…d friendly (envoyproxy#4505) * Reduce the amount and style of configuration logging Signed-off-by: Evan Anderson <[email protected]> * Update verbosity from 1->4 Signed-off-by: Evan Anderson <[email protected]> Signed-off-by: Evan Anderson <[email protected]> --------- Signed-off-by: Evan Anderson <[email protected]> Signed-off-by: Evan Anderson <[email protected]>
evankanderson
added a commit
to evankanderson/gateway
that referenced
this pull request
Oct 29, 2024
…d friendly (envoyproxy#4505) * Reduce the amount and style of configuration logging Signed-off-by: Evan Anderson <[email protected]> * Update verbosity from 1->4 Signed-off-by: Evan Anderson <[email protected]> Signed-off-by: Evan Anderson <[email protected]> --------- Signed-off-by: Evan Anderson <[email protected]> Signed-off-by: Evan Anderson <[email protected]>
arkodg
added a commit
to arkodg/gateway
that referenced
this pull request
Oct 31, 2024
https://pkg.go.dev/github.com/go-logr/zapr#hdr-Implementation_Details ``` V(1) is equivalent to Zap's DebugLevel ``` Now after setting the log level to `default: debug` I see ``` 2024-10-31T01:59:31.138Z DEBUG gateway-api runner/runner.go:176 {"proxy":{"metadata":{"labels":{"gateway.envoyproxy.io/owning-gateway-name":"eg","gateway.envoyproxy.io/owning-gateway-namespace":"default"}},"name":"default/eg","listeners":[{"name":"default/eg/http","address":null,"ports":[{"name":"http-80","protocol":"HTTP","servicePort":80,"containerPort":10080}]}]}} {"runner": "gateway-api", "infra-ir": "default/eg"} 2024-10-31T01:59:31.138Z DEBUG gateway-api runner/runner.go:187 {"accessLog":{"text":[{"path":"/dev/stdout"}]},"http":[{"name":"default/eg/http","address":"0.0.0.0","port":10080,"metadata":{"kind":"Gateway","name":"eg","namespace":"default","sectionName":"http"},"hostnames":["*"],"routes":[{"name":"httproute/default/backend/rule/0/match/0/www_example_com","hostname":"www.example.com","isHTTP2":false,"pathMatch":{"name":"","prefix":"/","distinct":false},"destination":{"name":"httproute/default/backend/rule/0","settings":[{"weight":1,"protocol":"HTTP","endpoints":[{"host":"10.1.19.7","port":3000}],"addressType":"IP"}]},"metadata":{"kind":"HTTPRoute","name":"backend","namespace":"default"}}],"isHTTP2":false,"path":{"mergeSlashes":true,"escapedSlashesAction":"UnescapeAndRedirect"}}]} {"runner": "gateway-api", "xds-ir": "default/eg"} ``` Relates to envoyproxy#4505 Signed-off-by: Arko Dasgupta <[email protected]>
arkodg
added a commit
that referenced
this pull request
Oct 31, 2024
https://pkg.go.dev/github.com/go-logr/zapr#hdr-Implementation_Details ``` V(1) is equivalent to Zap's DebugLevel ``` Now after setting the log level to `default: debug` I see ``` 2024-10-31T01:59:31.138Z DEBUG gateway-api runner/runner.go:176 {"proxy":{"metadata":{"labels":{"gateway.envoyproxy.io/owning-gateway-name":"eg","gateway.envoyproxy.io/owning-gateway-namespace":"default"}},"name":"default/eg","listeners":[{"name":"default/eg/http","address":null,"ports":[{"name":"http-80","protocol":"HTTP","servicePort":80,"containerPort":10080}]}]}} {"runner": "gateway-api", "infra-ir": "default/eg"} 2024-10-31T01:59:31.138Z DEBUG gateway-api runner/runner.go:187 {"accessLog":{"text":[{"path":"/dev/stdout"}]},"http":[{"name":"default/eg/http","address":"0.0.0.0","port":10080,"metadata":{"kind":"Gateway","name":"eg","namespace":"default","sectionName":"http"},"hostnames":["*"],"routes":[{"name":"httproute/default/backend/rule/0/match/0/www_example_com","hostname":"www.example.com","isHTTP2":false,"pathMatch":{"name":"","prefix":"/","distinct":false},"destination":{"name":"httproute/default/backend/rule/0","settings":[{"weight":1,"protocol":"HTTP","endpoints":[{"host":"10.1.19.7","port":3000}],"addressType":"IP"}]},"metadata":{"kind":"HTTPRoute","name":"backend","namespace":"default"}}],"isHTTP2":false,"path":{"mergeSlashes":true,"escapedSlashesAction":"UnescapeAndRedirect"}}]} {"runner": "gateway-api", "xds-ir": "default/eg"} ``` Relates to #4505 Signed-off-by: Arko Dasgupta <[email protected]>
zhaohuabing
pushed a commit
to zhaohuabing/gateway
that referenced
this pull request
Nov 1, 2024
https://pkg.go.dev/github.com/go-logr/zapr#hdr-Implementation_Details ``` V(1) is equivalent to Zap's DebugLevel ``` Now after setting the log level to `default: debug` I see ``` 2024-10-31T01:59:31.138Z DEBUG gateway-api runner/runner.go:176 {"proxy":{"metadata":{"labels":{"gateway.envoyproxy.io/owning-gateway-name":"eg","gateway.envoyproxy.io/owning-gateway-namespace":"default"}},"name":"default/eg","listeners":[{"name":"default/eg/http","address":null,"ports":[{"name":"http-80","protocol":"HTTP","servicePort":80,"containerPort":10080}]}]}} {"runner": "gateway-api", "infra-ir": "default/eg"} 2024-10-31T01:59:31.138Z DEBUG gateway-api runner/runner.go:187 {"accessLog":{"text":[{"path":"/dev/stdout"}]},"http":[{"name":"default/eg/http","address":"0.0.0.0","port":10080,"metadata":{"kind":"Gateway","name":"eg","namespace":"default","sectionName":"http"},"hostnames":["*"],"routes":[{"name":"httproute/default/backend/rule/0/match/0/www_example_com","hostname":"www.example.com","isHTTP2":false,"pathMatch":{"name":"","prefix":"/","distinct":false},"destination":{"name":"httproute/default/backend/rule/0","settings":[{"weight":1,"protocol":"HTTP","endpoints":[{"host":"10.1.19.7","port":3000}],"addressType":"IP"}]},"metadata":{"kind":"HTTPRoute","name":"backend","namespace":"default"}}],"isHTTP2":false,"path":{"mergeSlashes":true,"escapedSlashesAction":"UnescapeAndRedirect"}}]} {"runner": "gateway-api", "xds-ir": "default/eg"} ``` Relates to envoyproxy#4505 Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit e6307f0) Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing
pushed a commit
to zhaohuabing/gateway
that referenced
this pull request
Nov 6, 2024
…d friendly (envoyproxy#4505) * Reduce the amount and style of configuration logging Signed-off-by: Evan Anderson <[email protected]> * Update verbosity from 1->4 Signed-off-by: Evan Anderson <[email protected]> Signed-off-by: Evan Anderson <[email protected]> --------- Signed-off-by: Evan Anderson <[email protected]> Signed-off-by: Evan Anderson <[email protected]> (cherry picked from commit 7897fc5) Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing
pushed a commit
to zhaohuabing/gateway
that referenced
this pull request
Nov 6, 2024
https://pkg.go.dev/github.com/go-logr/zapr#hdr-Implementation_Details ``` V(1) is equivalent to Zap's DebugLevel ``` Now after setting the log level to `default: debug` I see ``` 2024-10-31T01:59:31.138Z DEBUG gateway-api runner/runner.go:176 {"proxy":{"metadata":{"labels":{"gateway.envoyproxy.io/owning-gateway-name":"eg","gateway.envoyproxy.io/owning-gateway-namespace":"default"}},"name":"default/eg","listeners":[{"name":"default/eg/http","address":null,"ports":[{"name":"http-80","protocol":"HTTP","servicePort":80,"containerPort":10080}]}]}} {"runner": "gateway-api", "infra-ir": "default/eg"} 2024-10-31T01:59:31.138Z DEBUG gateway-api runner/runner.go:187 {"accessLog":{"text":[{"path":"/dev/stdout"}]},"http":[{"name":"default/eg/http","address":"0.0.0.0","port":10080,"metadata":{"kind":"Gateway","name":"eg","namespace":"default","sectionName":"http"},"hostnames":["*"],"routes":[{"name":"httproute/default/backend/rule/0/match/0/www_example_com","hostname":"www.example.com","isHTTP2":false,"pathMatch":{"name":"","prefix":"/","distinct":false},"destination":{"name":"httproute/default/backend/rule/0","settings":[{"weight":1,"protocol":"HTTP","endpoints":[{"host":"10.1.19.7","port":3000}],"addressType":"IP"}]},"metadata":{"kind":"HTTPRoute","name":"backend","namespace":"default"}}],"isHTTP2":false,"path":{"mergeSlashes":true,"escapedSlashesAction":"UnescapeAndRedirect"}}]} {"runner": "gateway-api", "xds-ir": "default/eg"} ``` Relates to envoyproxy#4505 Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit e6307f0) Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing
added a commit
that referenced
this pull request
Nov 6, 2024
* Reduce the amount of configuration logging, and make it line-delimeted friendly (#4505) * Reduce the amount and style of configuration logging Signed-off-by: Evan Anderson <[email protected]> * Update verbosity from 1->4 Signed-off-by: Evan Anderson <[email protected]> Signed-off-by: Evan Anderson <[email protected]> --------- Signed-off-by: Evan Anderson <[email protected]> Signed-off-by: Evan Anderson <[email protected]> (cherry picked from commit 7897fc5) Signed-off-by: Huabing Zhao <[email protected]> * feat: enable load backend resources (#4535) enable load backend resources Signed-off-by: shawnh2 <[email protected]> (cherry picked from commit 9c9f435) Signed-off-by: Huabing Zhao <[email protected]> * build(deps): bump actions/setup-node from 4.0.4 to 4.1.0 (#4537) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.0.4 to 4.1.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@0a44ba7...39370e3) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 6ccbbac) Signed-off-by: Huabing Zhao <[email protected]> * chore: optimized code (#4514) * chore: optimized code Signed-off-by: zirain <[email protected]> * revert Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> (cherry picked from commit 7ad18fa) Signed-off-by: Huabing Zhao <[email protected]> * build(deps): bump github/codeql-action from 3.26.13 to 3.27.0 (#4538) Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.13 to 3.27.0. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@f779452...6624720) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit a13f384) Signed-off-by: Huabing Zhao <[email protected]> * build(deps): bump distroless/static from `26f9b99` to `3a03fc0` in /tools/docker/envoy-gateway (#4541) build(deps): bump distroless/static in /tools/docker/envoy-gateway Bumps distroless/static from `26f9b99` to `3a03fc0`. --- updated-dependencies: - dependency-name: distroless/static dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 6667e4c) Signed-off-by: Huabing Zhao <[email protected]> * build(deps): bump actions/setup-go from 5.0.2 to 5.1.0 in /tools/github-actions/setup-deps (#4540) build(deps): bump actions/setup-go in /tools/github-actions/setup-deps Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.0.2 to 5.1.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@0a12ed9...41dfa10) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit de72c77) Signed-off-by: Huabing Zhao <[email protected]> * build(deps): bump github.com/replicatedhq/troubleshoot from 0.107.1 to 0.107.4 (#4543) build(deps): bump github.com/replicatedhq/troubleshoot Bumps [github.com/replicatedhq/troubleshoot](https://github.com/replicatedhq/troubleshoot) from 0.107.1 to 0.107.4. - [Release notes](https://github.com/replicatedhq/troubleshoot/releases) - [Commits](replicatedhq/troubleshoot@v0.107.1...v0.107.4) --- updated-dependencies: - dependency-name: github.com/replicatedhq/troubleshoot dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 189325b) Signed-off-by: Huabing Zhao <[email protected]> * build(deps): bump github.com/tsaarni/certyaml from 0.9.3 to 0.10.0 (#4546) Bumps [github.com/tsaarni/certyaml](https://github.com/tsaarni/certyaml) from 0.9.3 to 0.10.0. - [Release notes](https://github.com/tsaarni/certyaml/releases) - [Commits](tsaarni/certyaml@v0.9.3...v0.10.0) --- updated-dependencies: - dependency-name: github.com/tsaarni/certyaml dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 5e397ea) Signed-off-by: Huabing Zhao <[email protected]> * build(deps): bump actions/checkout from 4.2.1 to 4.2.2 (#4539) Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.1 to 4.2.2. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@eef6144...11bd719) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit a9e5cfe) Signed-off-by: Huabing Zhao <[email protected]> * build(deps): bump github.com/fatih/color from 1.17.0 to 1.18.0 (#4545) Bumps [github.com/fatih/color](https://github.com/fatih/color) from 1.17.0 to 1.18.0. - [Release notes](https://github.com/fatih/color/releases) - [Commits](fatih/color@v1.17.0...v1.18.0) --- updated-dependencies: - dependency-name: github.com/fatih/color dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 902925f) Signed-off-by: Huabing Zhao <[email protected]> * e2e test for Gateway with EnvoyProxy (#4548) * e2e test for Gateway with EnvoyProxy Signed-off-by: Huabing Zhao <[email protected]> * remove unnecessary comments Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> (cherry picked from commit 217c6a5) Signed-off-by: Huabing Zhao <[email protected]> * make watching alpha CRDs optional (#4519) * make watching alpha CRDs optional * The ownership of CRD installation is not tied to a single entity https://gateway-api.sigs.k8s.io/guides/crd-management/#who-should-manage-crds This results in multiple entities taking ownership of CRD installation * infra users * implementations * cloud providers This complicates things for implementations who may not know which version and release of CRDs are installed, so this PR makes watching alpha versioned CRDs optional * Even Envoy Gateway specific CRDs have been made optional to solve the use case where users want to only configure Gateway API resources * GRPCRoute is the only exception, which is v1, but has been made optional because it just graduated to v1 in v1.2 but a lot of cloud providers or service mesh implementations have not moved to v1.2 Fixes: #3387 Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit b877bac) Signed-off-by: Huabing Zhao <[email protected]> * fix: validate proto messages before converting them to anypb.Any (#4499) * validate proto message before converting to any Signed-off-by: Huabing Zhao <[email protected]> (cherry picked from commit 05817fc) Signed-off-by: Huabing Zhao <[email protected]> * Fix: xds translation failed when wasm http code source configured without sha (#4547) * fix wasm http code source without sha Signed-off-by: Huabing Zhao <[email protected]> * release note Signed-off-by: Huabing Zhao <[email protected]> * fix gen Signed-off-by: Huabing Zhao <[email protected]> * fix gen Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> (cherry picked from commit 74e5750) Signed-off-by: Huabing Zhao <[email protected]> * build(deps): bump sigs.k8s.io/controller-runtime from 0.19.0 to 0.19.1 (#4544) * build(deps): bump sigs.k8s.io/controller-runtime from 0.19.0 to 0.19.1 Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.19.0 to 0.19.1. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.19.0...v0.19.1) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * fix gen check Signed-off-by: zirain <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: zirain <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zirain <[email protected]> Co-authored-by: Huabing Zhao <[email protected]> (cherry picked from commit f5552a4) Signed-off-by: Huabing Zhao <[email protected]> * feat(chart): Make security context configurable (#4536) * Make security context configurable Signed-off-by: Tamal Saha <[email protected]> * make gen-check Signed-off-by: Tamal Saha <[email protected]> * Update current.yaml Signed-off-by: Tamal Saha <[email protected]> --------- Signed-off-by: Tamal Saha <[email protected]> (cherry picked from commit 20a4622) Signed-off-by: Huabing Zhao <[email protected]> * helm: make eg-addons support IPv6 cluster (#4559) Signed-off-by: zirain <[email protected]> (cherry picked from commit b0c6f8c) Signed-off-by: Huabing Zhao <[email protected]> * ci: cleanup osv-scanner config (#4579) Signed-off-by: Shahar Harari <[email protected]> (cherry picked from commit 1a275b9) Signed-off-by: Huabing Zhao <[email protected]> * fix egctl release artifacts (#4580) * the release artifact for `egctl` was being pulled from the `latest` release instead of a binary associated with the release tag Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 82ce107) Signed-off-by: Huabing Zhao <[email protected]> * fix debug level logging for IR (#4584) https://pkg.go.dev/github.com/go-logr/zapr#hdr-Implementation_Details ``` V(1) is equivalent to Zap's DebugLevel ``` Now after setting the log level to `default: debug` I see ``` 2024-10-31T01:59:31.138Z DEBUG gateway-api runner/runner.go:176 {"proxy":{"metadata":{"labels":{"gateway.envoyproxy.io/owning-gateway-name":"eg","gateway.envoyproxy.io/owning-gateway-namespace":"default"}},"name":"default/eg","listeners":[{"name":"default/eg/http","address":null,"ports":[{"name":"http-80","protocol":"HTTP","servicePort":80,"containerPort":10080}]}]}} {"runner": "gateway-api", "infra-ir": "default/eg"} 2024-10-31T01:59:31.138Z DEBUG gateway-api runner/runner.go:187 {"accessLog":{"text":[{"path":"/dev/stdout"}]},"http":[{"name":"default/eg/http","address":"0.0.0.0","port":10080,"metadata":{"kind":"Gateway","name":"eg","namespace":"default","sectionName":"http"},"hostnames":["*"],"routes":[{"name":"httproute/default/backend/rule/0/match/0/www_example_com","hostname":"www.example.com","isHTTP2":false,"pathMatch":{"name":"","prefix":"/","distinct":false},"destination":{"name":"httproute/default/backend/rule/0","settings":[{"weight":1,"protocol":"HTTP","endpoints":[{"host":"10.1.19.7","port":3000}],"addressType":"IP"}]},"metadata":{"kind":"HTTPRoute","name":"backend","namespace":"default"}}],"isHTTP2":false,"path":{"mergeSlashes":true,"escapedSlashesAction":"UnescapeAndRedirect"}}]} {"runner": "gateway-api", "xds-ir": "default/eg"} ``` Relates to #4505 Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit e6307f0) Signed-off-by: Huabing Zhao <[email protected]> * docs: remove List type (#4585) Signed-off-by: zirain <[email protected]> (cherry picked from commit 13490ac) Signed-off-by: Huabing Zhao <[email protected]> * ci: enable test for dual stack cluster (#4574) * ci: enable dual stack test Signed-off-by: zirain <[email protected]> * more comment Signed-off-by: zirain <[email protected]> * remove 1.31.0 ipv4 test suite Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> (cherry picked from commit bb3bbdb) Signed-off-by: Huabing Zhao <[email protected]> * build(deps): bump the k8s-io group across 2 directories with 6 updates (#4542) * build(deps): bump the k8s-io group across 2 directories with 6 updates Bumps the k8s-io group with 4 updates in the / directory: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver), [k8s.io/cli-runtime](https://github.com/kubernetes/cli-runtime) and [k8s.io/kubectl](https://github.com/kubernetes/kubectl). Bumps the k8s-io group with 1 update in the /examples/extension-server directory: [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery). Updates `k8s.io/api` from 0.31.1 to 0.31.2 - [Commits](kubernetes/api@v0.31.1...v0.31.2) Updates `k8s.io/apiextensions-apiserver` from 0.31.1 to 0.31.2 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.31.1...v0.31.2) Updates `k8s.io/apimachinery` from 0.31.1 to 0.31.2 - [Commits](kubernetes/apimachinery@v0.31.1...v0.31.2) Updates `k8s.io/cli-runtime` from 0.31.1 to 0.31.2 - [Commits](kubernetes/cli-runtime@v0.31.1...v0.31.2) Updates `k8s.io/client-go` from 0.31.1 to 0.31.2 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.31.1...v0.31.2) Updates `k8s.io/kubectl` from 0.31.1 to 0.31.2 - [Commits](kubernetes/kubectl@v0.31.1...v0.31.2) Updates `k8s.io/apimachinery` from 0.31.1 to 0.31.2 - [Commits](kubernetes/apimachinery@v0.31.1...v0.31.2) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/cli-runtime dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/kubectl dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch dependency-group: k8s-io ... Signed-off-by: dependabot[bot] <[email protected]> * fix gen Signed-off-by: zirain <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zirain <[email protected]> Co-authored-by: Huabing Zhao <[email protected]> (cherry picked from commit 74f4377) Signed-off-by: Huabing Zhao <[email protected]> * chore: remove dump (#4593) Signed-off-by: zirain <[email protected]> (cherry picked from commit efe625d) Signed-off-by: Huabing Zhao <[email protected]> * fix: trigger reconcile for Secret updates referenced by a BackendTLSP… (#4581) fix: trigger reconcile for Secret updates referenced by a BackendTLSPolicy Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit db68027) Signed-off-by: Huabing Zhao <[email protected]> * chore: use net.JoinHostPort (#4599) * chore: use net.JoinHostPort Signed-off-by: zirain <[email protected]> * more fix Signed-off-by: zirain <[email protected]> * remove netutils.JoinHostPort Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> (cherry picked from commit 6e2587d) Signed-off-by: Huabing Zhao <[email protected]> * fix keycloak ipv6 issue (#4601) (cherry picked from commit d42915a) Signed-off-by: Huabing Zhao <[email protected]> * fix: Route with multiple parents has incorrect namespace in parentRef status (#4592) fix route status wrong ns Signed-off-by: Huabing Zhao <[email protected]> (cherry picked from commit 7285dda) Signed-off-by: Huabing Zhao <[email protected]> * add envoy-gateway binary to release artifacts (#4588) Fixes: #4566 Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit b51c66a) Signed-off-by: Huabing Zhao <[email protected]> * [release/v1.1] release v1.1.3 (#4600) * release: v1.1.3 Signed-off-by: Guy Daich <[email protected]> * remove gw-api, fix style Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Guy Daich <[email protected]> (cherry picked from commit a88e6eb) Signed-off-by: Huabing Zhao <[email protected]> * chore: donot use space in short name (#4608) Signed-off-by: zirain <[email protected]> (cherry picked from commit ee33b28) Signed-off-by: Huabing Zhao <[email protected]> * Move v1.1 docs tag to v1.1.2 (#4615) Wait until v1.1.3 tag is ready Fixes: #4614 Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 656ce52) Signed-off-by: Huabing Zhao <[email protected]> * fix: HTTPRoute status only shows one parent when targeting multiple Gateways from different GatewayClasses (#4587) * fix route status Signed-off-by: Huabing Zhao <[email protected]> * address comment Signed-off-by: Huabing Zhao <[email protected]> * update unit test Signed-off-by: Huabing Zhao <[email protected]> * fix lint Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> (cherry picked from commit 04ac7b4) Signed-off-by: Huabing Zhao <[email protected]> * direct response docs and tests (#4583) * tests: direct response Signed-off-by: Arko Dasgupta <[email protected]> * unit tests Signed-off-by: Arko Dasgupta <[email protected]> * fix ns Signed-off-by: Arko Dasgupta <[email protected]> * docs for direct response Signed-off-by: Arko Dasgupta <[email protected]> * negative tests Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit f384a64) Signed-off-by: Huabing Zhao <[email protected]> * build(deps): bump github.com/fsnotify/fsnotify from 1.7.0 to 1.8.0 (#4619) Bumps [github.com/fsnotify/fsnotify](https://github.com/fsnotify/fsnotify) from 1.7.0 to 1.8.0. - [Release notes](https://github.com/fsnotify/fsnotify/releases) - [Changelog](https://github.com/fsnotify/fsnotify/blob/main/CHANGELOG.md) - [Commits](fsnotify/fsnotify@v1.7.0...v1.8.0) --- updated-dependencies: - dependency-name: github.com/fsnotify/fsnotify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 6f91867) Signed-off-by: Huabing Zhao <[email protected]> * build(deps): bump github.com/bufbuild/buf from 1.45.0 to 1.46.0 in /tools/src/buf (#4616) build(deps): bump github.com/bufbuild/buf in /tools/src/buf Bumps [github.com/bufbuild/buf](https://github.com/bufbuild/buf) from 1.45.0 to 1.46.0. - [Release notes](https://github.com/bufbuild/buf/releases) - [Changelog](https://github.com/bufbuild/buf/blob/main/CHANGELOG.md) - [Commits](bufbuild/buf@v1.45.0...v1.46.0) --- updated-dependencies: - dependency-name: github.com/bufbuild/buf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Huabing Zhao <[email protected]> (cherry picked from commit 2265862) Signed-off-by: Huabing Zhao <[email protected]> * remove myself from maintainers (#4624) remove myself from maintainers and update github user Signed-off-by: Alice Lilith <[email protected]> (cherry picked from commit 1205ccf) Signed-off-by: Huabing Zhao <[email protected]> * e2e: move apps to examples and pre-built (#4576) * e2e: move grpc-ext-auth envoy-als to examples Signed-off-by: zirain <[email protected]> (cherry picked from commit a011146) Signed-off-by: Huabing Zhao <[email protected]> * fix: wasm oci image source e2e test failed when IP_FAMILY=ipv6 (#4623) fixt wasm test” Signed-off-by: Huabing Zhao <[email protected]> (cherry picked from commit 7b85d22) Signed-off-by: Huabing Zhao <[email protected]> * workaroud for the flaky oidc e2e test (#4603) * workaroud for the flaky oidc e2e test Signed-off-by: Huabing Zhao <[email protected]> * add issue link Signed-off-by: Huabing Zhao <[email protected]> * address comment Signed-off-by: Huabing Zhao <[email protected]> * fix test Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> (cherry picked from commit b0ab317) Signed-off-by: Huabing Zhao <[email protected]> * build(deps): bump softprops/action-gh-release from 2.0.8 to 2.0.9 (#4622) Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 2.0.8 to 2.0.9. - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@c062e08...e7a8f85) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Huabing Zhao <[email protected]> (cherry picked from commit 26a63e1) Signed-off-by: Huabing Zhao <[email protected]> * Set ignore_health_on_host_removal to true for static clusters (#4612) Removes the endpoint from the pool faster instead of waiting for the result of the active health. Since the control plane already has definitive endpoint health info from the EndpointSlice API, its safe to set this. Fixes: #4564 Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 1a57daf) Signed-off-by: Huabing Zhao <[email protected]> * build(deps): bump github.com/prometheus/common from 0.60.0 to 0.60.1 (#4620) Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.60.0 to 0.60.1. - [Release notes](https://github.com/prometheus/common/releases) - [Changelog](https://github.com/prometheus/common/blob/main/RELEASE.md) - [Commits](prometheus/common@v0.60.0...v0.60.1) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit e5968c9) Signed-off-by: Huabing Zhao <[email protected]> * build(deps): bump github.com/replicatedhq/troubleshoot from 0.107.4 to 0.107.5 (#4621) build(deps): bump github.com/replicatedhq/troubleshoot Bumps [github.com/replicatedhq/troubleshoot](https://github.com/replicatedhq/troubleshoot) from 0.107.4 to 0.107.5. - [Release notes](https://github.com/replicatedhq/troubleshoot/releases) - [Commits](replicatedhq/troubleshoot@v0.107.4...v0.107.5) --- updated-dependencies: - dependency-name: github.com/replicatedhq/troubleshoot dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 976e6a1) Signed-off-by: Huabing Zhao <[email protected]> * add docker.io registry name in image name (#4628) * add docker.io registry name in image name Fixes: #4626 Signed-off-by: Arko Dasgupta <[email protected]> * add api file Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit cc71048) Signed-off-by: Huabing Zhao <[email protected]> * docs: Jwt claim based authorization (#4617) * docs for jwt claim auth Signed-off-by: Huabing Zhao <[email protected]> * add docs for JWT claim based authorization Signed-off-by: Huabing Zhao <[email protected]> * minor change Signed-off-by: Huabing Zhao <[email protected]> * fix lint Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> (cherry picked from commit da4a060) Signed-off-by: Huabing Zhao <[email protected]> * build(deps): bump github.com/ohler55/ojg from 1.24.1 to 1.25.0 (#4618) Bumps [github.com/ohler55/ojg](https://github.com/ohler55/ojg) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ohler55/ojg/releases) - [Changelog](https://github.com/ohler55/ojg/blob/develop/CHANGELOG.md) - [Commits](ohler55/ojg@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: github.com/ohler55/ojg dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zirain <[email protected]> (cherry picked from commit 2d68e6a) Signed-off-by: Huabing Zhao <[email protected]> * e2e: use grafana alloy instead of fluent-bit (#4525) * use grafana alloy instead of fluent-bit Signed-off-by: zirain <[email protected]> * make alloy disabled by default Signed-off-by: zirain <[email protected]> * enable alloy in e2e Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> (cherry picked from commit 3191d49) Signed-off-by: Huabing Zhao <[email protected]> * chore: update site docs link for latest release (#4634) update site docs link for latest release Signed-off-by: Guy Daich <[email protected]> (cherry picked from commit 5698e88) Signed-off-by: Huabing Zhao <[email protected]> * fix: push a helm chart without v in ther version (#4636) * push a helm chart without v in ther version Signed-off-by: Huabing Zhao <[email protected]> * rename tag Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> (cherry picked from commit f2c8b77) Signed-off-by: Huabing Zhao <[email protected]> * add envoy-gateway binary to latest release artifacts (#4638) * add envoy-gateway binary to latest release artifcats Missed in #4566 Signed-off-by: Arko Dasgupta <[email protected]> * fix also in tagged release Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 7b6834e) Signed-off-by: Huabing Zhao <[email protected]> * fix: BackendTlsPolicy specify multiple targetRefs of the same service, only one will work (#4630) * add tests Signed-off-by: Huabing Zhao <[email protected]> * fix matching comparison Signed-off-by: Huabing Zhao <[email protected]> * add release note Signed-off-by: Huabing Zhao <[email protected]> * fix lint Signed-off-by: Huabing Zhao <[email protected]> * fix lint Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> (cherry picked from commit 44c2f74) Signed-off-by: Huabing Zhao <[email protected]> * fix build Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Evan Anderson <[email protected]> Signed-off-by: Evan Anderson <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: shawnh2 <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: Tamal Saha <[email protected]> Signed-off-by: Shahar Harari <[email protected]> Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Alice Lilith <[email protected]> Co-authored-by: Evan Anderson <[email protected]> Co-authored-by: sh2 <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zirain <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: Tamal Saha <[email protected]> Co-authored-by: shahar-h <[email protected]> Co-authored-by: Guy Daich <[email protected]> Co-authored-by: Alice Lilith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix: Gateway API currently logs multi-line JSON objects in the otherwise line-delimited logs.
What this PR does / why we need it:
I noticed (looking through our logs system, which collects line-delimited logs from containers using fluent-bit) a number of logs of the form:
Needless to say, stitching these logs back into a coherent stream is a bit of a chore. Additionally, it seems like envoy-gateway is logging most of the desired configuration every 1-2 minutes by default, which seems a bit excessive, particularly as configuration gets larger.
I've moved the configuration dumps behind a
-v 1log verbosity flag, and collapsed the JSON onto a single (very long) line. Defaulting to structured logs might make more sense, but I'm wondering if you actually need to log all the configuration, including both the k8s object (with annotations!) and the full envoy config.Which issue(s) this PR fixes:
I did not open an issue for this, as the fix seemed feasible to simply do.
Release Notes: Yes