Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update logo #4469

Merged
merged 2 commits into from
Oct 19, 2024
Merged

chore: update logo #4469

merged 2 commits into from
Oct 19, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented Oct 17, 2024

Signed-off-by: zirain <[email protected]>
@zirain zirain requested a review from a team as a code owner October 17, 2024 15:39
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.59%. Comparing base (aab669d) to head (11dd29d).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4469      +/-   ##
==========================================
- Coverage   65.83%   65.59%   -0.24%     
==========================================
  Files         200      200              
  Lines       24285    30268    +5983     
==========================================
+ Hits        15987    19854    +3867     
- Misses       7159     9274    +2115     
- Partials     1139     1140       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg
Copy link
Contributor

arkodg commented Oct 17, 2024

the alignment doesnt look right to me, wdyt @zirain @missBerg
https://github.com/cncf/artwork/blob/main/examples/graduated.md#envoy-gateway-logos
either should be left aligned or center aligned

@arkodg
Copy link
Contributor

arkodg commented Oct 18, 2024

Signed-off-by: zirain <[email protected]>
@arkodg arkodg requested review from a team October 18, 2024 00:23
@shawnh2 shawnh2 merged commit 8c748d3 into envoyproxy:main Oct 19, 2024
27 checks passed
@zirain zirain deleted the logo branch October 19, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants