fix: enforce connection limit value #4458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4458 +/- ##
==========================================
+ Coverage 65.97% 66.01% +0.04%
==========================================
Files 203 203
Lines 31154 31154
==========================================
+ Hits 20554 20567 +13
+ Misses 9415 9404 -11
+ Partials 1185 1183 -2 ☔ View full report in Codecov by Sentry. |
arkodg
reviewed
Oct 16, 2024
api/v1alpha1/connection_types.go
Outdated
| // | ||
| // +kubebuilder:validation:Minimum=0 | ||
| // +kubebuilder:validation:Minimum=1 | ||
| Value int64 `json:"value,omitempty"` |
arkodg
reviewed
Oct 21, 2024
api/v1alpha1/connection_types.go
Outdated
| @@ -63,13 +63,13 @@ type BackendConnection struct { | |||
| SocketBufferLimit *resource.Quantity `json:"socketBufferLimit,omitempty"` | |||
| } | |||
|
|
|||
| // +kubebuilder:validation:XValidation:rule="(has(self.value))",message="value must be specified" | |||
There was a problem hiding this comment.
nit: not needed since Value is now mandatory
arkodg
previously approved these changes
Oct 21, 2024
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
guydc
force-pushed
the
fix-empty-conn-limit
branch
from
81d5a7f to
96bc751
Compare
zirain
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4457