feat: allow running EnvoyProxy as DaemonSet #4429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jukie <[email protected]>
zirain
reviewed
Oct 12, 2024
Signed-off-by: jukie <[email protected]>
Signed-off-by: jukie <[email protected]>
jukie
changed the title
jukie
changed the title
Signed-off-by: jukie <[email protected]>
Signed-off-by: jukie <[email protected]>
jukie
changed the title
Signed-off-by: jukie <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4429 +/- ##
==========================================
+ Coverage 65.82% 65.85% +0.02%
==========================================
Files 200 200
Lines 24177 24226 +49
==========================================
+ Hits 15915 15953 +38
- Misses 7128 7134 +6
- Partials 1134 1139 +5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: jukie <[email protected]>
jukie
changed the title
|
/retest |
Signed-off-by: jukie <[email protected]>
|
Should actually work this time 🤞 |
shawnh2
reviewed
Oct 13, 2024
internal/infrastructure/kubernetes/ratelimit/resource_provider.go
Outdated
Show resolved
Hide resolved
Signed-off-by: jukie <[email protected]>
|
/retest |
shawnh2
reviewed
Oct 13, 2024
There was a problem hiding this comment.
Hi @jukie, thanks for implementing the rest part of daemonset deploy mode, code generally LGTM!
Got a question about EG and RateLimit both in daemonset settings: the EG and RL pod will be running on each node, does it mean the global rate limiting becomes per-node rate limiting?
|
/retest |
Signed-off-by: jukie <[email protected]>
jukie
force-pushed
the
fix-daemonset-mode
branch
from
133cb21 to
f3ec861
Compare
Signed-off-by: jukie <[email protected]>
jukie
force-pushed
the
fix-daemonset-mode
branch
from
f3ec861 to
36100da
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Signed-off-by: jukie <[email protected]>
zirain
reviewed
Oct 13, 2024
zirain
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat: allow running EnvoyProxy as DaemonSet
What this PR does / why we need it:
Continuation of #3092 to finish all daemonset implementations and fix a bug where the gateway status never gets updated because the code only checks for deployments.
Which issue(s) this PR fixes:
Fixes #4416
Fixes #2969