fix dashboard typos #4422
Merged
fix dashboard typos #4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIRC, that json generated from jsonnet, can you update it and then run cc @shawnh2 |
shawnh2
previously approved these changes
Oct 10, 2024
| @@ -1849,7 +1849,7 @@ | |||
| "uid": "${datasource}" | |||
| }, | |||
| "editorMode": "builder", | |||
| "expr": "sum by(namespace) (rate(envoy_cluster_upstream_cx_rx_bytes_total{namespace=~\"$Namespace\"}[5m]))", | |||
| "expr": "sum by(namespace) (rate(envoy_cluster_upstream_cx_tx_bytes_total{namespace=~\"$Namespace\"}[5m]))", | |||
not really, these json are legacy dashboards, not generated from jsonnet. |
|
please run |
Signed-off-by: haorenfsa <[email protected]>
@shawnh2 done |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4422 +/- ##
==========================================
- Coverage 65.77% 65.72% -0.05%
==========================================
Files 200 200
Lines 24141 24141
==========================================
- Hits 15878 15866 -12
- Misses 7133 7139 +6
- Partials 1130 1136 +6 ☔ View full report in Codecov by Sentry. |
|
/retest |
zirain
approved these changes
Oct 10, 2024
juwon8891
pushed a commit
to juwon8891/gateway
that referenced
this pull request
Oct 22, 2024
Signed-off-by: haorenfsa <[email protected]>
guydc
pushed a commit
to guydc/gateway
that referenced
this pull request
Oct 30, 2024
Signed-off-by: haorenfsa <[email protected]> Signed-off-by: Guy Daich <[email protected]>
guydc
added a commit
that referenced
this pull request
Oct 31, 2024
* build(deps): bump github.com/docker/docker from 27.2.0+incompatible to 27.3.1+incompatible (#4303) build(deps): bump github.com/docker/docker Bumps [github.com/docker/docker](https://github.com/docker/docker) from 27.2.0+incompatible to 27.3.1+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v27.2.0...v27.3.1) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Huabing Zhao <[email protected]> (cherry picked from commit cd4e9b1) Signed-off-by: Guy Daich <[email protected]> * bugfix: EG loglevel error for admin and metrics module (#4340) * bugfix: EG loglevel error for admin and metrics module Signed-off-by: qicz <[email protected]> * fix ut Signed-off-by: qicz <[email protected]> * polish Signed-off-by: qicz <[email protected]> --------- Signed-off-by: qicz <[email protected]> (cherry picked from commit 9b161ee) Signed-off-by: Guy Daich <[email protected]> * fix: some status updates are discarded by the status updater (#4337) Signed-off-by: Huabing Zhao <[email protected]> (cherry picked from commit 14830c7) Signed-off-by: Guy Daich <[email protected]> * fix: Unsupported listener protocol type error for nil supportKinds assign gateway status. (#4345) (cherry picked from commit 7babca9) Signed-off-by: Guy Daich <[email protected]> * set invalid Listener.SupportedKinds to empty list (#4352) * set invalid Listener.SupportedKinds to empty list Fixes: #4216 Relates to https://kubernetes.slack.com/archives/CR0H13KGA/p1727457195236889 Signed-off-by: Arko Dasgupta <[email protected]> * lint Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 2fdf069) Signed-off-by: Guy Daich <[email protected]> * bugfix: ignore some unnecessary requests to apiserver. (#4362) Signed-off-by: qicz <[email protected]> Co-authored-by: zirain <[email protected]> (cherry picked from commit fe1e8bd) Signed-off-by: Guy Daich <[email protected]> * fix: rateLimitDeployment ignoring pod labels and annotation merge (#4228) * fix labels and annotation merges for rate limit deployment Signed-off-by: Oscar Boher <[email protected]> * fix tests and label merge Signed-off-by: Oscar Boher <[email protected]> * fix annotation merge if prometheus was disabled and annotations were defined Signed-off-by: Oscar Boher <[email protected]> * renamed labels and annotations to specify they apply to pods only Signed-off-by: Oscar Boher <[email protected]> * linter Signed-off-by: Oscar Boher <[email protected]> * fix resource provider tests to new annotation behavior Signed-off-by: Oscar Boher <[email protected]> * go linter Signed-off-by: Oscar Boher <[email protected]> * fix gen-check Signed-off-by: Oscar Boher <[email protected]> * pod labels selector comment Signed-off-by: Oscar Boher <[email protected]> --------- Signed-off-by: Oscar Boher <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> (cherry picked from commit cf84927) Signed-off-by: Guy Daich <[email protected]> * fix dashboard typos (#4422) Signed-off-by: haorenfsa <[email protected]> Signed-off-by: Guy Daich <[email protected]> * fix: ratelimit not working with both headers and cidr matches (#4377) * fix ratelimit descriptors do not respect both headers and cidr match for one rule Signed-off-by: shawnh2 <[email protected]> * fix gen-check and lint Signed-off-by: shawnh2 <[email protected]> * fix ratelimit e2e test Signed-off-by: shawnh2 <[email protected]> * add more comment and update test case Signed-off-by: shawnh2 <[email protected]> --------- Signed-off-by: shawnh2 <[email protected]> Co-authored-by: Huabing Zhao <[email protected]> (cherry picked from commit 66c0b51) Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Guy Daich <[email protected]> Signed-off-by: qicz <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: Oscar Boher <[email protected]> Signed-off-by: haorenfsa <[email protected]> Signed-off-by: shawnh2 <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Huabing Zhao <[email protected]> Co-authored-by: qi <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Oscar Boher <[email protected]> Co-authored-by: shaoyue <[email protected]> Co-authored-by: sh2 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix: some typos in Grafana dashboard.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4421