Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade test should use VERSION by default #4393

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented Oct 6, 2024

fixes: #4343

xref: #4384

@zirain zirain requested a review from a team as a code owner October 6, 2024 01:51
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.69%. Comparing base (87b8418) to head (4fb1e77).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4393      +/-   ##
==========================================
+ Coverage   65.67%   65.69%   +0.02%     
==========================================
  Files         200      200              
  Lines       24128    24128              
==========================================
+ Hits        15845    15851       +6     
+ Misses       7145     7142       -3     
+ Partials     1138     1135       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain zirain mentioned this pull request Oct 6, 2024
test/e2e/tests/eg_upgrade.go Outdated Show resolved Hide resolved
@zirain zirain requested a review from guydc October 8, 2024 11:17
@zirain zirain requested review from a team October 9, 2024 05:22
Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shawnh2 shawnh2 merged commit b9f594c into envoyproxy:main Oct 9, 2024
24 checks passed
@zirain zirain deleted the use-1.1.2 branch October 9, 2024 12:45
zhaohuabing added a commit to zhaohuabing/gateway that referenced this pull request Oct 25, 2024
zhaohuabing added a commit to zhaohuabing/gateway that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants