Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix patch command for adding TLS gateway listener #4316

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

Dean-Coakley
Copy link
Contributor

Which issue(s) this PR fixes:

Fixes #4022

@Dean-Coakley Dean-Coakley requested a review from a team as a code owner September 23, 2024 14:46
@Dean-Coakley Dean-Coakley force-pushed the fix-patch-req branch 2 times, most recently from 30a0303 to 0b4539a Compare September 23, 2024 16:26
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@arkodg arkodg requested review from a team September 23, 2024 16:48
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.66%. Comparing base (2bd27dd) to head (26eeaa3).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4316      +/-   ##
==========================================
- Coverage   65.67%   65.66%   -0.01%     
==========================================
  Files         197      197              
  Lines       23565    23565              
==========================================
- Hits        15476    15474       -2     
- Misses       6980     6981       +1     
- Partials     1109     1110       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain zirain merged commit e5fe849 into envoyproxy:main Sep 23, 2024
25 of 27 checks passed
@Dean-Coakley Dean-Coakley deleted the fix-patch-req branch September 23, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: use kubectl patch with --type=merge in docs
3 participants