Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove comma #4300

Merged
merged 1 commit into from
Sep 24, 2024
Merged

docs: remove comma #4300

merged 1 commit into from
Sep 24, 2024

Conversation

muffl0n
Copy link
Contributor

@muffl0n muffl0n commented Sep 22, 2024

What this PR does / why we need it:
Remove comma

@muffl0n muffl0n requested a review from a team as a code owner September 22, 2024 02:58
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.80%. Comparing base (475cd61) to head (10ac907).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4300      +/-   ##
==========================================
+ Coverage   65.66%   65.80%   +0.13%     
==========================================
  Files         197      197              
  Lines       23565    23767     +202     
==========================================
+ Hits        15474    15639     +165     
- Misses       6982     7013      +31     
- Partials     1109     1115       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain
Copy link
Member

zirain commented Sep 22, 2024

please fix latest and v1.1 then run make -k gen-check

@arkodg
Copy link
Contributor

arkodg commented Sep 23, 2024

@muffl0n can you also fix the same issue in site/content/en/latest/tasks/quickstart.md & site/content/en/v1.1/tasks/quickstart.md

Signed-off-by: Sven Schliesing <[email protected]>
@muffl0n
Copy link
Contributor Author

muffl0n commented Sep 24, 2024

Sure thing!

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@arkodg arkodg merged commit 4a3e324 into envoyproxy:main Sep 24, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants