Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(translator): client tls session resumption #4293
feat(translator): client tls session resumption #4293
Changes from 11 commits
bd0c9f2
7f02edf
c7bc8e8
8c33695
37dc4d7
465d11f
ef4eee5
d24d5c0
077fc64
ed17d7e
ac5fd29
6ccd727
8082c9e
44bca91
0dc2b80
638dee6
60846bb
7f10fb6
c12d1f6
5d4b1f9
d50e0dc
cf1510e
f7a782e
b884742
bffd67f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use following structure?
if there're more than 1 property with session prefix, prefer to move them into a struct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the
timeout
be part of thesessionResumption
setting?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it seems that different implementations have different meanings for session timeout.
BoringSSL seems to treat this as a hard timeout after which a new handshake is required:
In envoy, this is also used as a hint on session tickets.
OpenSSL seems to treat this as a soft timeout after which resumption cannot occur, but an active session may still continue (?):
@arkodg requested that we leave
sessionTimeout
out of this PR. I will change the API to @zirain's proposal, to support for future addition of session-related settings that are not specific to resumption.Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Check warning on line 879 in internal/gatewayapi/clienttrafficpolicy.go
Codecov / codecov/patch
internal/gatewayapi/clienttrafficpolicy.go#L879
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sessionTimeout
clean up needed here