Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support inverting header matches for rate limit #4286

Merged
merged 1 commit into from
Oct 10, 2024

feat: support inverting header matches for rate limit

5c645de
Select commit
Loading
Failed to load commit list.
Merged

feat: support inverting header matches for rate limit #4286

feat: support inverting header matches for rate limit
5c645de
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 9, 2024 in 0s

65.72% (target 60.00%)

View this Pull Request on Codecov

65.72% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.72%. Comparing base (d1cc0ba) to head (5c645de).

Files with missing lines Patch % Lines
internal/xds/translator/local_ratelimit.go 50.00% 1 Missing and 1 partial ⚠️
internal/gatewayapi/backendtrafficpolicy.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4286   +/-   ##
=======================================
  Coverage   65.71%   65.72%           
=======================================
  Files         200      200           
  Lines       24128    24141   +13     
=======================================
+ Hits        15856    15866   +10     
- Misses       7138     7139    +1     
- Partials     1134     1136    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.