-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gateway API 1.2.0] Upgrade Gateway API to 1.2.0-rc2 #4270
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
186b7fa
to
abdaefd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4270 +/- ##
==========================================
+ Coverage 65.98% 66.02% +0.03%
==========================================
Files 197 197
Lines 23972 23996 +24
==========================================
+ Hits 15819 15844 +25
Misses 7026 7026
+ Partials 1127 1126 -1 ☔ View full report in Codecov by Sentry. |
1b20f32
to
84b4bd4
Compare
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
bda6dfe
to
9d6b609
Compare
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
@@ -274,13 +275,14 @@ func migrateChartCRDs(actionConfig *action.Configuration, gatewayChart *chart.Ch | |||
} | |||
|
|||
for _, crd := range crds { | |||
if crd.Name == "backendtlspolicies.gateway.networking.k8s.io" { | |||
if crd.Name == "backendtlspolicies.gateway.networking.k8s.io" || | |||
crd.Name == "grpcroutes.gateway.networking.k8s.io" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://gateway-api.sigs.k8s.io/guides/?h=upgrade#v11-upgrade-notes
GRPCRoute graduated to GA, and the v1alpha2 was removed.
implement: #4269
GatewayInfrastructure has been disabled and tracked with the issue: #4330