fix: Switch to an immediate drain strategy #4230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensures clients immediately receive a `connection: close` / `GOAWAY` instead of a probabilistic approach of receiving one b/w drain start and drain end (defaults to 600s). This should speed up shutdown with clients reconnecting to newer upgraded proxies. Fixes: envoyproxy#4205 Signed-off-by: Arko Dasgupta <[email protected]>
arkodg
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4230 +/- ##
==========================================
+ Coverage 66.45% 66.48% +0.03%
==========================================
Files 195 195
Lines 23734 23732 -2
==========================================
+ Hits 15773 15779 +6
+ Misses 6838 6833 -5
+ Partials 1123 1120 -3 ☔ View full report in Codecov by Sentry. |
guydc
approved these changes
Sep 12, 2024
|
/retest |
zirain
approved these changes
Sep 13, 2024
guydc
pushed a commit
to guydc/gateway
that referenced
this pull request
Sep 23, 2024
Switch to a immediate drain strategy * Ensures clients immediately receive a `connection: close` / `GOAWAY` instead of a probabilistic approach of receiving one b/w drain start and drain end (defaults to 600s). This should speed up shutdown with clients reconnecting to newer upgraded proxies. Fixes: envoyproxy#4205 Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 14f687f) Signed-off-by: Guy Daich <[email protected]>
guydc
pushed a commit
to guydc/gateway
that referenced
this pull request
Sep 23, 2024
Switch to a immediate drain strategy * Ensures clients immediately receive a `connection: close` / `GOAWAY` instead of a probabilistic approach of receiving one b/w drain start and drain end (defaults to 600s). This should speed up shutdown with clients reconnecting to newer upgraded proxies. Fixes: envoyproxy#4205 Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 14f687f) Signed-off-by: Guy Daich <[email protected]>
arkodg
added a commit
that referenced
this pull request
Sep 24, 2024
* fix: Reconcile on HTTPRoute labels change (#4279) * added label change predicate Signed-off-by: Luv <[email protected]> * added labels predicate for xroute and gw Signed-off-by: Luv <[email protected]> * changed predicate to use .Or Signed-off-by: Luv <[email protected]> --------- Signed-off-by: Luv <[email protected]> Co-authored-by: zirain <[email protected]> (cherry picked from commit 0d1ccae) Signed-off-by: Guy Daich <[email protected]> * fix: handle invalid sectionName in BackendTLSPolicy for Backend (#4296) (cherry picked from commit 73c223e) Signed-off-by: Guy Daich <[email protected]> * fix: Switch to an immediate drain strategy (#4230) Switch to a immediate drain strategy * Ensures clients immediately receive a `connection: close` / `GOAWAY` instead of a probabilistic approach of receiving one b/w drain start and drain end (defaults to 600s). This should speed up shutdown with clients reconnecting to newer upgraded proxies. Fixes: #4205 Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 14f687f) Signed-off-by: Guy Daich <[email protected]> --------- Signed-off-by: Luv <[email protected]> Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Co-authored-by: Luv <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connection: close/GOAWAYinstead of a probabilistic approach of receiving one b/w drain start and drain end (defaults to 600s). This should speed up shutdown with clients reconnecting to newer upgraded proxies.Fixes: #4205