Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add test for RecomputeRoute in ExtAuth #4222

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

zirain
Copy link
Member

@zirain zirain commented Sep 12, 2024

fixes: #3609

@zirain zirain requested a review from a team as a code owner September 12, 2024 03:30
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.63%. Comparing base (1fbbe98) to head (82d496f).
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4222   +/-   ##
=======================================
  Coverage   65.63%   65.63%           
=======================================
  Files         197      197           
  Lines       23540    23540           
=======================================
  Hits        15451    15451           
+ Misses       6979     6978    -1     
- Partials     1110     1111    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkodg arkodg merged commit 9cf7828 into envoyproxy:main Sep 19, 2024
24 checks passed
@zirain zirain deleted the ext-auth branch September 19, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support RecomputeRoute for Ext Auth
3 participants