Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump to golang1.23.1 #4206

Merged
merged 4 commits into from
Sep 11, 2024
Merged

ci: bump to golang1.23.1 #4206

merged 4 commits into from
Sep 11, 2024

Conversation

zirain
Copy link
Member

@zirain zirain commented Sep 10, 2024

crd-ref-docs and controller-gen still keep in golang1.22.7 because the change of types.

tools/bin/controller-gen crd:allowDangerousTypes=true paths="./api/..." output:crd:artifacts:config=charts/gateway-helm/crds/generated
panic: interface conversion: types.Type is *types.Alias, not *types.Named

Signed-off-by: zirain <[email protected]>
@zirain zirain requested a review from a team as a code owner September 10, 2024 11:33
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.52%. Comparing base (c109131) to head (032781b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4206      +/-   ##
==========================================
- Coverage   67.99%   66.52%   -1.48%     
==========================================
  Files         190      195       +5     
  Lines       23130    23699     +569     
==========================================
+ Hits        15727    15765      +38     
- Misses       6284     6814     +530     
- Partials     1119     1120       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arkodg
arkodg previously approved these changes Sep 10, 2024
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@arkodg arkodg requested review from a team September 10, 2024 16:59
@zirain
Copy link
Member Author

zirain commented Sep 10, 2024

seems related to https://go.dev/doc/go1.23#gotypespkggotypes, not 100% sure.

@zirain
Copy link
Member Author

zirain commented Sep 10, 2024

ah, always failed on go1.23.x, intresting!

    --- FAIL: TestE2E/CookieBasedSessionPersistence (1.03s)
        --- FAIL: TestE2E/CookieBasedSessionPersistence/traffic_is_routed_based_on_cookie_based_session_persistence (1.01s)

@arkodg arkodg requested review from a team September 11, 2024 15:17
@arkodg arkodg merged commit e26c162 into envoyproxy:main Sep 11, 2024
27 checks passed
@zirain zirain deleted the bump-go-1.23 branch September 11, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants