Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: add Untyped metadata support in ExtProc #4160

Closed
wants to merge 3 commits into from

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Sep 5, 2024

xref: #4152

@zirain zirain requested a review from a team as a code owner September 5, 2024 09:35
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.95%. Comparing base (69bf882) to head (9fd5be4).
Report is 237 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4160   +/-   ##
=======================================
  Coverage   67.94%   67.95%           
=======================================
  Files         190      190           
  Lines       23113    23113           
=======================================
+ Hits        15704    15706    +2     
+ Misses       6287     6286    -1     
+ Partials     1122     1121    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zirain <[email protected]>
@zirain zirain changed the title api: add metadata support in ExtProc api: add Untyped metadata support in ExtProc Sep 5, 2024
@zirain zirain requested a review from guydc September 5, 2024 16:05
@zirain zirain changed the title api: add Untyped metadata support in ExtProc api: add Untyped metadata support in ExtProc Sep 5, 2024
Copy link
Contributor

@guydc guydc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

@github-actions github-actions bot added stale and removed stale labels Oct 29, 2024
@zirain zirain closed this Nov 6, 2024
This was referenced Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants