Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: removes unimplemented attributes in the extproc example #4115

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Aug 26, 2024

What type of PR is this?
the title says.

What this PR does / why we need it:
This document is misleading by using unimplemented field named "attributes"
which presumably will be implemented in #3170

Which issue(s) this PR fixes:
N/A

@mathetake mathetake requested a review from a team as a code owner August 26, 2024 21:43
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@arkodg arkodg requested review from a team August 26, 2024 21:44
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.91%. Comparing base (cc8acbd) to head (a418e0d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4115      +/-   ##
==========================================
+ Coverage   67.90%   67.91%   +0.01%     
==========================================
  Files         187      187              
  Lines       23032    23032              
==========================================
+ Hits        15639    15643       +4     
+ Misses       6273     6271       -2     
+ Partials     1120     1118       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zirain zirain merged commit bf03975 into envoyproxy:main Aug 27, 2024
23 of 27 checks passed
@mathetake mathetake deleted the removeexternunimplemented branch August 27, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants